Closed Bug 430461 Opened 13 years ago Closed 13 years ago

Don't hold back the AwesomeBar (start the searches instantly)

Categories

(Firefox :: Address Bar, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 3

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

(Keywords: polish)

Attachments

(1 file)

Bug 414254 added a 100ms delay to searching for performance reasons, but bug 422177 (and bug 422490, bug 422491) should address the performance issues.

Removing the delay would get rid of the artificial wait before any results can show up, so things will be snappier. Users won't have to wait to press down to select the first entry.
Flags: blocking-firefox3?
Attached patch v1Splinter Review
timeout=100.. Baleeted!
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #317276 - Flags: review?(mconnor)
(doesn't block, but provides a responsiveness gain)
Flags: blocking-firefox3? → blocking-firefox3-
Comment on attachment 317276 [details] [diff] [review]
v1

r+a=beltzner
Attachment #317276 - Flags: review?(mconnor)
Attachment #317276 - Flags: review+
Attachment #317276 - Flags: approval1.9+
http://hg.mozilla.org/cvs-trunk-mirror/index.cgi/rev/c3dc5fdb15f4
http://hg.mozilla.org/mozilla-central/index.cgi/rev/c3dc5fdb15f4

Checking in browser/base/content/browser.xul;
/cvsroot/mozilla/browser/base/content/browser.xul,v  <--  browser.xul
new revision: 1.463; previous revision: 1.462
done
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: blocking-firefox3- → blocking-firefox3?
Keywords: polish
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3
Flags: blocking-firefox3?
A really small delay is visible for the first search. Further searches opens the Awesome bar instantly.

Verified.

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9pre) Gecko/2008042806 Minefield/3.0pre ID:2008042806

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008042906 Minefield/3.0pre
Status: RESOLVED → VERIFIED
As I pointed in #435576, starting the search instantly can prevent the user from correctly filling the url bar.

Typing the first letter fires a 100% CPU usage that can lead to Firefox missing the next letters typed by the user. 

I am seeing this behaviour on my iMac 2.8Ghz, but this is very annoying on my iBook G4...

I think that the previous behaviour should be reverted, maybe with a lower timeout.
Depends on: 435576
You need to log in before you can comment on or make changes to this bug.