Closed Bug 430466 Opened 16 years ago Closed 16 years ago

Geos with 0 latitude or longitude aren't defined properly

Categories

(Toolkit Graveyard :: Microformats, defect)

Product:
Toolkit Graveyard
Component:
Microformats
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mkaply, Assigned: mkaply)

Details

Attachments

(1 file)

Fix + testcase
6.45 KB, patch
sayrer
: review+
damons
: approval1.9+
Details | Diff | Splinter Review
Attached patch Fix + testcase — — Splinter Review 
When the checking was added for invalid geos, somehow I missed testing for geos with 0/0.

Basically all my checking for "result" in my code fails with a 0 geo, because 0 is false.

I should be checking for undefined.

Testcases attached as well.
Attachment #317281 - Flags: review?(sayrer)
This was a dumb mistake that needs to be fixed.
Flags: blocking1.9?
Comment on attachment 317281 [details] [diff] [review]
Fix + testcase

Truthiness gets to us all every now and again.
Attachment #317281 - Flags: review?(sayrer) → review+
Comment on attachment 317281 [details] [diff] [review]
Fix + testcase

Note that the recurseExternalFrames stuff in here is a separate patch and won't go in.

Sorry about that.

This is a very simple fix that makes "0" geos work.
Attachment #317281 - Flags: approval1.9?
Comment on attachment 317281 [details] [diff] [review]
Fix + testcase

a1.9+=damons
Attachment #317281 - Flags: approval1.9? → approval1.9+
Fix checked in.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Flags: blocking1.9? → blocking1.9+
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: