Closed Bug 430474 Opened 17 years ago Closed 17 years ago

Crashes in KeychainItem loadKeychainData

Categories

(Camino Graveyard :: OS Integration, defect)

x86
macOS
defect
Not set
critical

Tracking

(Not tracked)

RESOLVED FIXED
Camino2.0

People

(Reporter: stuart.morgan+bugzilla, Assigned: stuart.morgan+bugzilla)

Details

(Keywords: fixed1.8.1.15)

Attachments

(1 file)

We have some crashes in -[KeychainItem loadKeychainData]; probably null data in a field I wasn't expecting. All those assignments should be bullet-proofed.
Flags: camino1.6.1+
Attached patch speculative fixSplinter Review
It looks like someone in the forum may have this problem, so hopefully we can get a build with this change tested, but even if this isn't the actual crash we still should do this.
Assignee: nobody → stuart.morgan
Status: NEW → ASSIGNED
Attachment #317725 - Flags: superreview?(mikepinkerton)
Comment on attachment 317725 [details] [diff] [review] speculative fix sr=pink
Attachment #317725 - Flags: superreview?(mikepinkerton) → superreview+
Landed on trunk and MOZILLA_1_8_BRANCH. I'll be optimistic and close this, and if 1.6.1 Talkback (or testing of a nightly) still shows a crash, we can re-open for further investigation.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: fixed1.8.1.15
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: