Crashes in KeychainItem loadKeychainData

RESOLVED FIXED in Camino2.0

Status

--
critical
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: stuart.morgan+bugzilla, Assigned: stuart.morgan+bugzilla)

Tracking

({fixed1.8.1.15})

Trunk
Camino2.0
x86
Mac OS X
fixed1.8.1.15
Bug Flags:
camino1.6.1 +

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
We have some crashes in -[KeychainItem loadKeychainData]; probably null data in a field I wasn't expecting. All those assignments should be bullet-proofed.
Flags: camino1.6.1+
(Assignee)

Comment 1

11 years ago
Created attachment 317725 [details] [diff] [review]
speculative fix

It looks like someone in the forum may have this problem, so hopefully we can get a build with this change tested, but even if this isn't the actual crash we still should do this.
Assignee: nobody → stuart.morgan
Status: NEW → ASSIGNED
Attachment #317725 - Flags: superreview?(mikepinkerton)
Comment on attachment 317725 [details] [diff] [review]
speculative fix

sr=pink
Attachment #317725 - Flags: superreview?(mikepinkerton) → superreview+
(Assignee)

Comment 3

11 years ago
Landed on trunk and MOZILLA_1_8_BRANCH. I'll be optimistic and close this, and if 1.6.1 Talkback (or testing of a nightly) still shows a crash, we can re-open for further investigation.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.1.15
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.