Closed Bug 430540 Opened 14 years ago Closed 12 years ago

Microformats in a floated div are not displayed (they are hidden)


(Toolkit Graveyard :: Microformats, defect)

Not set


(Not tracked)



(Reporter: mkaply, Assigned: mkaply)





(2 files)

Currently in the microformats code I use the box object or bounding rect to determine if a microformat is visible on the screen or not. In cases where a microformat is marked as a float left or right and has only block level children, that microformat is marked invisible even though its children are visible.

For the fix, I enumerate one level down to see if the children are visible.

I tried going through all descendants, but that impacted performance. This should cover most cases.
Attachment #317359 - Flags: review?(sayrer)
shouldn't we be able to test this? Patches at this point in the release cycle absolutely must have tests.
Attached patch Unit testSplinter Review
Here's the unit test
Sorry, I had simply forgotten to add the test.
Attachment #317366 - Attachment is patch: true
Attachment #317366 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 317366 [details] [diff] [review]
Unit test

Sorry, I didn't attach the unit test the first time.
Attachment #317366 - Flags: review?(sayrer)
Attachment #317359 - Flags: review?(sayrer) → review+
Attachment #317366 - Flags: review?(sayrer) → review+
Fix checked in.
Comment on attachment 317359 [details] [diff] [review]
Fix for problem - enumerate first level children's visibility

Microformats correctness
Attachment #317359 - Flags: approval1.9.0.3?
Comment on attachment 317359 [details] [diff] [review]
Fix for problem - enumerate first level children's visibility

In order to reduce risk and minimize overhead for stability releases, we are not accepting "nice to have" patches in stability releases.  As 3.1 is fast approaching, this should not unduly impact time to get these fixes to users.
Attachment #317359 - Flags: approval1.9.0.4? → approval1.9.0.4-
This was fixed on trunk.
Closed: 12 years ago
Resolution: --- → FIXED
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.