430597 - New clearListButton does not accommodate larger fonts

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Ed Hume]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008042305 Minefield/3.0pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008042305 Minefield/3.0pre

The new addition to downloads.css is

#clearListButton {
  min-height: 0;
  min-width: 0;
  height: 1em;
}

Unfortunately, when a somewhat larger-than-microscopic font is used, this produces a button that is not large enough to accommodate the text. See first attachment.

When this code is omitted from downloads.css (at least in my theme), the button displays normally. See second attachment.

Reproducible: Always




Process failure: lack of routine testing of browser elements against larger
font sizes. Since the testing is not done routinely, this kind of bug appears
routinely.

Comment 1

[Ed Hume]

Attachment: clearListButton height set to 1 em

Comment 2

[Ed Hume]

Attachment: clearListButton min-height set to 1.3 em. Same seen with code block removed (no height set)

Comment 3

[Alfred Kayser]

Just remove the 'height:1em' completely...

Comment 4

[Ed Hume]

Right. We themers can remove that code. But what about users who have their systems set to larger fonts. The default theme looks amateurish.

Please confirm this so we can get the devs' attention.

Comment 6

[Ed Lee :Mardak]

http://hg.mozilla.org/cvs-trunk-mirror/index.cgi/rev/e8f7ad982adf#l5.7

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

-> v.