optimized jsshell should use the same jsinterp.c options as the browser

RESOLVED FIXED

Status

()

enhancement
RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: igor, Assigned: igor)

Tracking

Trunk
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

v1b
643 bytes, patch
igor
: review+
Details | Diff | Splinter Review
Posted patch v1 (obsolete) — Splinter Review
Currently a non-debug browser build uses -O3 -fstrict-aliasing when compiling jsinterp.c with GCC while an optimized build of the shell still sets INTERP_OPTIMIZER to -Os. To minimize differences between the shell and the browser it would be nice to set when compiling the shell INTERP_OPTIMIZER also to "-O3 -fstrict-aliasing".

The attached patch does exactly that.
Attachment #317477 - Flags: review?(mrbkap)
Comment on attachment 317477 [details] [diff] [review]
v1

Yikes, sorry this fell through the cracks.
Attachment #317477 - Flags: review?(mrbkap) → review+
Posted patch v1bSplinter Review
The new version syncs the patch with trunk changes.
Attachment #317477 - Attachment is obsolete: true
Attachment #328455 - Flags: review+
fixed: http://hg.mozilla.org/mozilla-central/index.cgi/rev/c91b477f79b7
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Flags: in-litmus-
You need to log in before you can comment on or make changes to this bug.