Whitespace should be collapsed trim with value design pattern

RESOLVED FIXED

Status

()

Toolkit
Microformats
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: mkaply, Assigned: mkaply)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 317554 [details] [diff] [review]
Fix for problem plus unit test

There's a particular design pattern in microformats where multiple values are concatenated using the "value" class.

There was some debate on how this data should be processed, but in the end it has finally been decided that although whitespace is honored when constructing the end result, whitespace cleanup should then happen on that final result (similar to what happens with other microformat entities)

Patch attached with unit test.

Basically I separated the whitespace cleanup into its own function and call it before I return the result of the value concatenation.
Attachment #317554 - Flags: review?(sayrer)

Updated

10 years ago
Attachment #317554 - Flags: review?(sayrer) → review+
(Assignee)

Comment 1

10 years ago
fixed in hg
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Assignee)

Comment 2

10 years ago
Comment on attachment 317554 [details] [diff] [review]
Fix for problem plus unit test

Microformats correctness. Would be nice to have in 3.0
Attachment #317554 - Flags: approval1.9.0.3?
Comment on attachment 317554 [details] [diff] [review]
Fix for problem plus unit test

In order to reduce risk and minimize overhead for stability releases, we are not accepting "nice to have" patches in stability releases.  As 3.1 is fast approaching, this should not unduly impact time to get these fixes to users.
Attachment #317554 - Flags: approval1.9.0.4? → approval1.9.0.4-
You need to log in before you can comment on or make changes to this bug.