430672 - Whitespace should be collapsed trim with value design pattern

Status: RESOLVED FIXED

(Toolkit Graveyard :: Microformats, defect)

Description

[Mike Kaply [:mkaply]]

Attachment: Fix for problem plus unit test

There's a particular design pattern in microformats where multiple values are concatenated using the "value" class.

There was some debate on how this data should be processed, but in the end it has finally been decided that although whitespace is honored when constructing the end result, whitespace cleanup should then happen on that final result (similar to what happens with other microformat entities)

Patch attached with unit test.

Basically I separated the whitespace cleanup into its own function and call it before I return the result of the value concatenation.

Comment 1

[Mike Kaply [:mkaply]]

fixed in hg

Comment 2

[Mike Kaply [:mkaply]]

Comment on attachment 317554 [details] [diff] [review]
Fix for problem plus unit test

Microformats correctness. Would be nice to have in 3.0

Comment 3

[Mike Connor [:mconnor]]

Comment on attachment 317554 [details] [diff] [review]
Fix for problem plus unit test

In order to reduce risk and minimize overhead for stability releases, we are not accepting "nice to have" patches in stability releases.  As 3.1 is fast approaching, this should not unduly impact time to get these fixes to users.