Closed Bug 430685 Opened 15 years ago Closed 15 years ago

Small gray font in download manager is near-unreadable

Categories

(Toolkit :: Downloads API, defect, P2)

defect

Tracking

()

VERIFIED FIXED
mozilla1.9

People

(Reporter: zurtex, Assigned: Mardak)

References

Details

(Keywords: regression)

Attachments

(6 files)

Attached image XP vs Firefox Gray
As of:

Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9pre) Gecko/2008042407 Minefield/3.0pre ID:2008042407

The download manager now uses a very light gray for, size, status, time finished. This becomes very difficult to read when not sitting right up to the monitor and must be impossible for people who struggle reading on a computer anyway.

Firefox should use the more OS-native style colour that Microsoft uses for such extra data in Windows Explorer, see attached.
Flags: blocking-firefox3?
Mardak, are we pulling the right colour here? Looks OK on Vista, but I don't think this is doing anything great for us, so I'd also be fine with just backing out the greyText change.
Flags: blocking-firefox3? → blocking-firefox3+
faaborg says that this is all we have
Ok, let's back out the greytext.  I don't think its worth this.
Backing out the greytext will have the side effect of makeing it harder to differentiate between rows.  If we back it out I recommend we add some ThreeDhighlight lines similar to the awesomebar results.

Another idea: use the URL color for the second line?
I'm willing to live with the side effect.  We need to close this out to ship, we don't have time to keep iterating.  If we get a patch in the next six hours, I'll review and approve it, otherwise we need to just back it out and live with it not being optimal.
Attached image border on bottom
Attached patch v1 (checked in)Splinter Review
Make text black and add border on windows. Linux has odd-row-coloring and os x has background as well.
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #317661 - Flags: review?(mconnor)
Comment on attachment 317661 [details] [diff] [review]
v1 (checked in)

r+ui-r+a=me, ship it.
Attachment #317661 - Flags: ui-review+
Attachment #317661 - Flags: review?(mconnor)
Attachment #317661 - Flags: review+
Attachment #317661 - Flags: approval1.9+
http://hg.mozilla.org/cvs-trunk-mirror/index.cgi/rev/ace169a7da68
http://hg.mozilla.org/mozilla-central/index.cgi/rev/ace169a7da68

Checking in toolkit/themes/gnomestripe/mozapps/downloads/downloads.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/downloads/downloads.css,v  <--  downloads.css
new revision: 1.14; previous revision: 1.13
done
Checking in toolkit/themes/winstripe/mozapps/downloads/downloads.css;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/downloads/downloads.css,v  <--  downloads.css
new revision: 1.34; previous revision: 1.33
done
Blocks: 427179
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: regression
OS: Windows XP → All
Priority: -- → P2
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3
Uhm, MenuText? This isn't a menu, right? Why didn't you remove these style rules entirely?
Attachment #317697 - Flags: review?(edilee)
(In reply to comment #10)
> Uhm, MenuText? This isn't a menu, right? Why didn't you remove these style
> rules entirely?
It was to match the changes to the autocomplete styling as suggested by beltzner:
http://hg.mozilla.org/cvs-trunk-mirror/index.cgi/rev/61e4231f14cb#l2.6

And make it easier if we do want to use something like -moz-nativelinktext in the future.
Well, if we want a different color, we can add the rules back. They are useless right now, and MenuText is in fact technically wrong (the correct background color would be Menu). Also note that -moz-nativelinktext would be semantically wrong.
Why would it be Menu? We're styling the status text which has the domain link (probably why faaborg suggested "Another idea: use the URL color for the second line?")
(In reply to comment #14)
> Why would it be Menu?

Not sure what you mean. I wanted to say that the 'MenuText' text color is expected to be used together with the 'Menu' background color.

> We're styling the status text which has the domain link
> (probably why faaborg suggested "Another idea: use the URL color for the second
> line?")

It's not a link. Clicking it doesn't take you anywhere.
>It's not a link. Clicking it doesn't take you anywhere.

yeah, scratch that idea
Attachment #317697 - Flags: review?(edilee) → review+
Attachment #317697 - Flags: approval1.9?
Comment on attachment 317697 [details] [diff] [review]
cleanup (checked in)

a=beltzner
Attachment #317697 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Attachment #317661 - Attachment description: v1 → v1 (checked in)
Attached image look what you did
I should really read before assuming that the cleanup was what I expected it to be.

I don't actually think the grey line helps differentiate between rows at all on Vista. In fact, I think it's pretty horrendous looking and adds nothing but visual noise. Can we get a screenshot on XP? Is it similarly noisy?
The gray lines are from my patch (attachment 317661 [details] [diff] [review]) as suggested by faaborg and ui-r'd by mconnor. It's similar to the line separators for the location bar auto complete.

http://hg.mozilla.org/cvs-trunk-mirror/index.cgi/rev/ace169a7da68#l1.7
Yeah, I now know where they come from, I just think they're a mistake on Vista at least, and possibly on XP. I'm sure that the changes were meant well, but in practical usage, this jumped out at me as really, really awkward on Vista.
Attached image XP lines
I personally think the lines look o.k, but there we go
They look OK on XP. They look really out of place on Vista. I guess if I'm truly horrified, though, I know how to file a bug. Thanks for the screenshot.
mozilla/toolkit/themes/gnomestripe/mozapps/downloads/downloads.css 	1.15
mozilla/toolkit/themes/winstripe/mozapps/downloads/downloads.css 	1.35
Keywords: checkin-needed
Attachment #317697 - Attachment description: cleanup → cleanup (checked in)
Verified FIXED using:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9pre) Gecko/2008050904 Minefield/3.0pre

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008050906 Minefield/3.0pre

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008050906 Minefield/3.0pre

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008050904 Minefield/3.0pre
Status: RESOLVED → VERIFIED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.