When parsing a "tel" property, ignore type "type" when inferring the value.

RESOLVED FIXED

Status

()

Toolkit
Microformats
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: mkaply, Assigned: mkaply)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

(Assignee)

Description

10 years ago
Created attachment 317568 [details] [diff] [review]
Fix for problem plus unit test

This was discovered as a result of the new "microformat acid test" (http://microformatique.com/optimus/test.html)

Per the hcard spec, if a tel has no value but it does have a type, when you use the contents of the node to get the value, you are supposed to ignore the type node.

I was not doing this.

Patch and testcase is attached to fix this.

As I was doing this work, I removed "implied" from the overall "tel" and made "value" virtual and discovered that this made the "implied" behavior unnecessary.

At some point in time I made virtual work well enough that implied was not needed.

So this patch also removes implied support. (only one element was still "implied" - organization-name to org, and the test suite verifies this still works great)

So this patch removes some code and makes the referenced testcase work and adds two new tests to cover this case.
Attachment #317568 - Flags: review?(sayrer)
(Assignee)

Comment 1

10 years ago
Created attachment 321159 [details] [diff] [review]
Handle email case as well

Same problem exists for email, so here is patch and test.

This patch depends on previous patch.

Updated

10 years ago
Attachment #317568 - Flags: review?(sayrer) → review+
(Assignee)

Updated

10 years ago
Attachment #321159 - Flags: review?(sayrer)

Updated

10 years ago
Attachment #321159 - Flags: review?(sayrer) → review+
(Assignee)

Comment 2

10 years ago
fix checked in.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Assignee)

Comment 3

10 years ago
Comment on attachment 317568 [details] [diff] [review]
Fix for problem plus unit test

correctness fix for microformats
Attachment #317568 - Flags: approval1.9.0.3?
(Assignee)

Comment 4

10 years ago
Comment on attachment 321159 [details] [diff] [review]
Handle email case as well

microformats correctness fix
Attachment #321159 - Flags: approval1.9.0.3?
Comment on attachment 321159 [details] [diff] [review]
Handle email case as well

In order to reduce risk and minimize overhead for stability releases, we are not accepting "nice to have" patches in stability releases.  As 3.1 is fast approaching, this should not unduly impact time to get these fixes to users.
Attachment #321159 - Flags: approval1.9.0.4? → approval1.9.0.4-
Comment on attachment 317568 [details] [diff] [review]
Fix for problem plus unit test

In order to reduce risk and minimize overhead for stability releases, we are not accepting "nice to have" patches in stability releases.  As 3.1 is fast approaching, this should not unduly impact time to get these fixes to users.
Attachment #317568 - Flags: approval1.9.0.4? → approval1.9.0.4-
You need to log in before you can comment on or make changes to this bug.