If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

History items (Today, Yesterday, etc.) styling for Mac OS X

VERIFIED FIXED in Firefox 3

Status

()

Firefox
Theme
VERIFIED FIXED
10 years ago
10 years ago

People

(Reporter: mcdavis941 (sporadically reading bugmail), Assigned: shorlander)

Tracking

Trunk
Firefox 3
All
Mac OS X
Points:
---
Bug Flags:
blocking-firefox3 -
wanted-firefox3 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 3 obsolete attachments)

Spinning off from bug 425998 to be specific to Mac OS X.

There's currently no calendar icon in the tree for OS X ... I need confirmation on the intended design.

1. leave as is (shows as folder)

2. land and use a calendar icon as for other OS's in 
   Bug 425998

- or -

3. use the same icon as for history in Places Library 
   (shows as clock face) which would also be similar
   to styling in the Finder sidebar (which uses a clock
   face for today, yesterday, past week)
Blocks: 425998
Requesting blocking-firefox3 to get wanted-firefox3, same as Bug 425998
Flags: blocking-firefox3?
(Assignee)

Comment 2

10 years ago
Sorry, the Calendar icon fell off my radar. I will get one ASAP.
Wanted granted, but agree that it's not blocking. Target of opportunity. AIUI, as soon as we have an icon, the hookup is easy.
Flags: wanted-firefox3+
Flags: blocking-firefox3?
Flags: blocking-firefox3-
>Sorry, the Calendar icon fell off my radar. I will get one ASAP.

Sorry about that, it was mistakenly marked as not needed on the inventory.
Created attachment 317612 [details] [diff] [review]
pinstripe browser.css and places.css v1

These are the changes corresponding to what was done for other platforms and they look right on the surface.  Still, I can't yet build for the Mac, so if someone else wants to take this and finish it up for OS X that would be great.

I'm not sure under what conditions the browser.css rule would apply -- possibly with a user-defined query? -- but the selector was already there so now it uses the right icon.

Depends on places/calendar.png.
(Assignee)

Comment 6

10 years ago
Created attachment 317718 [details]
History Items

I applied the patch and the icon and it works in my build.
(Assignee)

Comment 7

10 years ago
Created attachment 317752 [details]
pinstripe browser.css and places.css v2

Slight update to mcdavis' patch including jar.mn changes for the new icon.
Attachment #317612 - Attachment is obsolete: true
Attachment #317752 - Flags: ui-review?
Attachment #317752 - Flags: review?
(Assignee)

Comment 8

10 years ago
Created attachment 317753 [details]
Proto Calendar Icon

New Calendar Icon
Attachment #317752 - Flags: review? → review+
Attachment #317752 - Flags: ui-review?(beltzner)
Attachment #317752 - Flags: ui-review?
Attachment #317752 - Flags: approval1.9?
Comment on attachment 317752 [details]
pinstripe browser.css and places.css v2

re-request approval once ui review has been completed.
Attachment #317752 - Flags: approval1.9?
Comment on attachment 317752 [details]
pinstripe browser.css and places.css v2

nit: I think that while we're using calendars on the other platforms, the OSX convention is to use the clock icon here. The patch is sound, but just s/calendar.png/whatever-the-clock-icon-is-called.png/ :)
Attachment #317752 - Flags: ui-review?(beltzner) → ui-review+
(Assignee)

Comment 11

10 years ago
Created attachment 318397 [details]
History Items Updated

Changed to Clock for platform and internal consistency. I will update the patch shortly.
Assignee: nobody → stephen
Attachment #317718 - Attachment is obsolete: true
Status: NEW → ASSIGNED
(Assignee)

Comment 12

10 years ago
Created attachment 318446 [details] [diff] [review]
pinstripe browser.css and places.css v3

Updated patch changing to history.png. Removed the calendar.png sections as they have moved to bug 429725. Does it need another review?
Attachment #317752 - Attachment is obsolete: true
Attachment #318446 - Flags: approval1.9?
Comment on attachment 318446 [details] [diff] [review]
pinstripe browser.css and places.css v3

a1.9=beltzner
Attachment #318446 - Flags: approval1.9? → approval1.9+
Hardware: Macintosh → All
(Assignee)

Comment 14

10 years ago
Checked in on 2008-05-05

mozilla/browser/themes/pinstripe/browser/browser.css 	1.152
mozilla/browser/themes/pinstripe/browser/places/places.css 	1.27 
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008051009 Minefield/3.0pre ID:2008051009
Status: RESOLVED → VERIFIED
Target Milestone: --- → Firefox 3
You need to log in before you can comment on or make changes to this bug.