430718 - Better objc exception logging with stack traces in debug builds

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

I was trying to track down an objc exception the other day and was frustrated by the fact that we don't know where the exceptions we're catching actually come from.

The attached patch pulls the stack information out of the exception itself and converts it to symbolic form using apple's atos tool. It even gets system calls in the trace! It's all DEBUG-only at the moment because you have to have the atos tool installed (although it fails gracefully if you don't) and that comes in the Developer Tools package.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v2

Josh pointed out that NSUInteger won't work on 10.4, so say hello to unsigned int!

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v3

10.4 also uses a different header (grr!) and doesn't have callStackReturnAddresses, so here's a version that should work properly on 10.4. Thanks, Josh, for testing on 10.4!

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v4

Apparently 10.4 warns for that selector while compiling even though it's runtime-safe... Here's a version that avoids the compiler warning.

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Final patch

Fixed comments and removed some braces.

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Checked in.