430757 - download box dimension is set to English text

Status: RESOLVED WORKSFORME

(www.mozilla.org :: General, defect)

Description

[Pascal Chevrel:pascalc (PTO until April 26)]

Attachment: screenshot showing the bug

The download box was designed to display the number of letters there is in "Get Firefox 3" and "Download now - Free", text gets outside of the green box and on top of the logo for all locales that use more letters.

The design should be flexible with a green box expanding horizontally and/or vertically and text that doesn't overflow the logo but flows around.s

Comment 1

[John Slater]

I know this situation was considered during the design process, and the button should have been built with this in mind. Steven, can you investigate?

Comment 2

[Steven Garrity [:sgarrity]]

Fixed in r12543.

Comment 3

[Pascal Chevrel:pascalc (PTO until April 26)]

Attachment: screenshot showing the bug

Comment 4

[Pascal Chevrel:pascalc (PTO until April 26)]

reopening, green box is displayed incorrectly after the patch

Comment 5

[Steven Garrity [:sgarrity]]

Pascal - a change to the Javascript/HTML that outputs the buttons per local is needed. See r12543. Should I do this to the other locales, or will you?

Comment 6

[Pascal Chevrel:pascalc (PTO until April 26)]

ok, I will do it when all locales are ready.

Comment 7

[Fernando Pereira Silveira]

Attachment: screenshot showing current state

This is the current state (at least on pt-BR). Is this the correct behaviour?

On security page it doesn't happen, since the risk graph increases the sidebar width.

Comment 8

[Steven Garrity [:sgarrity]]

(In reply to comment #7)
> This is the current state (at least on pt-BR). Is this the correct behaviour?

This box is intended to allow the title text to wrap. However, in this case, it's unfortunate that it's only the "3" bumped on to the next line. If we were to prevent the "Firefox 3" words from breaking, we'd end up with:

Obtenir
Firefox 3

rather than:

Obtenir Firefox
3

We could do that with a non-breaking space. To do it with CSS would require a SPAN around the "Firefox 3" text. Pascal, thoughts?

Comment 9

[Pascal Chevrel:pascalc (PTO until April 26)]

Fernando, in your main.lang file, put a non breaking space between Firefox and 3:

;Get Firefox 3
Obter Firefox 3

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

This happens with /ru/, too.

Comment 11

[Steven Garrity [:sgarrity]]

I've made a CSS change that should fix (r14531) that should fix /ru. Pascal, can you take a look? This change fixes the width of the sidebar download box in all pages (some had been wider than others).

Some locales might still benefit from the nbsp treatment.

Comment 12

[Michael Morgan [:morgamic]]

This seems ok -- Pascal, could you reopen if this is still an issue?