430816 - ads for eBay and State farm not blocked on listed website

Status: RESOLVED FIXED

(Camino Graveyard :: Annoyance Blocking, defect)

Description

[W Dodson]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en; rv:1.8.1.14) Gecko/20080409 Camino/1.6 (like Firefox/2.0.0.14)
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en; rv:1.8.1.14) Gecko/20080409 Camino/1.6 (like Firefox/2.0.0.14)

ads for eBay and State Farm not blocked on listed website. 

Reproducible: Sometimes

Steps to Reproduce:
1.leave website, then return later after visiting another site.
2.
3.
Actual Results:  
sometimes ebay not there on return visit, sometimes it is. State Farm there each time but more subtle ad than eBay.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

The eBay ads should be blockable based on the image servers; I'll have to do some more looking about the State Farm ad.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

philippe, can you think of any sane way to block the State Farm ads (or the "meet the locals"/"reviews" ads)?

Comment 3

[philippe (part-time)]

div[style*='statefarm_bg.gif'][style*='width: 300px'] catches the State Farm one. Not pretty but no too insane. Maybe safe to wrap that in a @-moz-document block.
(I added the width 300px to make sure it is limited to the add).

As for the other one(s): meet the locals and the TripAdvisor on its right. Can't they just warp that in div with class = advertisement ? :-(
Not many hooks in there unfortunately.

An insane way
.vaT .bm15+.bm15+.bm15+.bm15+table.full td.taC
which works today, but may just as well fail tomorrow. I'd use that kind of things in my own userstylesheet but can't recommend it otherwise.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #3)
> div[style*='statefarm_bg.gif'][style*='width: 300px'] catches the State Farm
> one. Not pretty but no too insane. Maybe safe to wrap that in a @-moz-document
> block.
> (I added the width 300px to make sure it is limited to the add).

I'm still on the fence about this one.  I guess it will block the ad across all pages on the site, but it's also not something that has a reasonable chance of being generic and applicable to other websites.

Comment 5

[philippe (part-time)]

(In reply to comment #4)
... 
> I'm still on the fence about this one.  I guess it will block the ad across all
> pages on the site, but it's also not something that has a reasonable chance of
> being generic and applicable to other websites.
>
That is why I suggested wrapping it in a @-moz-document block.
Going through a bunch of pages on the linked site didn't cause any issue, and checking the statefarm site worked correctly, afaict.
It could be even safer by using the whole path to the gif file
div[style*='icons-pe.wxug.com/graphics/statefarm_bg.gif'][style*='width: 300px']

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

FIXED on trunk by checkin of bug 421850.