430835 - talos errors for inability to contact graph server need improvement

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[alice nodelman [:alice] [:anode]]

The follow three cases need to raise better and more succinct errors on the tinderbox waterfall.

#1 Attempt to send data times out:
Traceback (most recent call last):
  File "run_tests.py", line 348, in ?
    test_file(arg)
  File "run_tests.py", line 332, in test_file
    send_to_graph(results_server, results_link, title, date, browser_config, results)
  File "run_tests.py", line 208, in send_to_graph
    links += post_chunk(results_server, results_link, res, filename)
  File "run_tests.py", line 135, in post_chunk
    ret = post_file.post_multipart(results_server, results_link, [("key", "value")], [("filename", filename, file_data)])
  File "C:\talos-slave\win32-trunk-mini-nochrome\talos\post_file.py", line 34, in post_multipart
    h.endheaders()
  File "C:\Python24\lib\httplib.py", line 798, in endheaders
    self._send_output()
  File "C:\Python24\lib\httplib.py", line 679, in _send_output
    self.send(msg)
  File "C:\Python24\lib\httplib.py", line 646, in send
    self.connect()
  File "C:\Python24\lib\httplib.py", line 630, in connect
    raise socket.error, msg
socket.error: (10060, 'Operation timed out')

#2 - Instead of timing out, throws some other socket connection error (probably still related to timeout - but could be that the connection on the graph server end was shut down mid-send)

Traceback (most recent call last):
  File "run_tests.py", line 348, in ?
    test_file(arg)
  File "run_tests.py", line 332, in test_file
    send_to_graph(results_server, results_link, title, date, browser_config, results)
  File "run_tests.py", line 208, in send_to_graph
    links += post_chunk(results_server, results_link, res, filename)
  File "run_tests.py", line 135, in post_chunk
    ret = post_file.post_multipart(results_server, results_link, [("key", "value")], [("filename", filename, file_data)])
  File "/Users/mozqa/talos-slave/mac-branch-fast/talos/post_file.py", line 34, in post_multipart
    h.endheaders()
  File "/Library/Frameworks/Python.framework/Versions/2.4//lib/python2.4/httplib.py", line 798, in endheaders
    self._send_output()
  File "/Library/Frameworks/Python.framework/Versions/2.4//lib/python2.4/httplib.py", line 679, in _send_output
    self.send(msg)
  File "/Library/Frameworks/Python.framework/Versions/2.4//lib/python2.4/httplib.py", line 646, in send
    self.connect()
  File "/Library/Frameworks/Python.framework/Versions/2.4//lib/python2.4/httplib.py", line 630, in connect
    raise socket.error, msg
socket.error: (22, 'Invalid argument')

#3 - attempt to check for graph server availability results in exception

FAIL: http://graphs.mozilla.org/bulk.cgi raises URLError (check if link exists)
Traceback (most recent call last):
  File "run_tests.py", line 348, in ?
    test_file(arg)
  File "run_tests.py", line 288, in test_file
    exit(0)
TypeError: 'str' object is not callable

Comment 1

[alice nodelman [:alice] [:anode]]

Attachment: catch and report post data errors

Comment 2

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 319889 [details] [diff] [review]
catch and report post data errors

that's some nice patchin', alice. I'm a little fuzzy on the BOUNDARY bit at the end though that is outside the scope of this review.

Comment 3

[alice nodelman [:alice] [:anode]]

Delayed to do a little baking on the staging talos boxes - everything there stayed green so checking in.

Checking in run_tests.py;
/cvsroot/mozilla/testing/performance/talos/run_tests.py,v  <--  run_tests.py
new revision: 1.28; previous revision: 1.27
done
Checking in post_file.py;
/cvsroot/mozilla/testing/performance/talos/post_file.py,v  <--  post_file.py
new revision: 1.4; previous revision: 1.3
done