If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Add hook for parameters

RESOLVED FIXED in Bugzilla 3.2

Status

()

Bugzilla
Administration
--
enhancement
RESOLVED FIXED
10 years ago
4 years ago

People

(Reporter: bbaetz, Assigned: bbaetz)

Tracking

3.1.3
Bugzilla 3.2
Bug Flags:
approval +

Details

Attachments

(1 attachment)

7.44 KB, patch
Max Kanat-Alexander
: review+
Frédéric Buclin
: review+
Details | Diff | Splinter Review
(Assignee)

Description

10 years ago
Created attachment 317819 [details] [diff] [review]
Patch

Extensions should be able to have their own parameters, via hooks.

Patch includes changes to the example plugin
Attachment #317819 - Flags: review?(mkanat)

Comment 1

10 years ago
  Since this is a hook, I'd like to see it in 3.2, but LpSolit has to agree.
Severity: normal → enhancement
Status: NEW → ASSIGNED
Component: Bugzilla-General → Administration
OS: Linux → All
Hardware: PC → All
Target Milestone: --- → Bugzilla 3.2

Comment 2

10 years ago
Comment on attachment 317819 [details] [diff] [review]
Patch

Looks good to me. This look good to you, LpSolit?
Attachment #317819 - Flags: review?(mkanat)
Attachment #317819 - Flags: review?(LpSolit)
Attachment #317819 - Flags: review+

Comment 3

10 years ago
Comment on attachment 317819 [details] [diff] [review]
Patch

>Index: Bugzilla/Config.pm

>+        my @new_param_list = "$module"->get_param_list();

Nit: quotes around $module are now useless AFAIK.



>Index: editparams.cgi

>+    my @module_param_list = "$module"->get_param_list(1);

Nit: same comment here.


>+    my @module_param_list = "$param_panels->{$current_module}"->get_param_list(1);

Nit: same comment here.


r=LpSolit with these useless quotes removed.
Attachment #317819 - Flags: review?(LpSolit) → review+

Comment 4

10 years ago
We are going to release 3.1.4. Maybe wait for the release before checking it in, in case we regress something.
Flags: approval?
(Assignee)

Comment 5

10 years ago
Yeah, will wait

Comment 6

10 years ago
Bugzilla 3.1.4 has been released. You can now check it in.
Flags: approval? → approval+
(Assignee)

Comment 7

10 years ago
Checked in:

Checking in Bugzilla/Config.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config.pm,v  <--  Config.pm
new revision: 1.74; previous revision: 1.73
done
Checking in editparams.cgi;
/cvsroot/mozilla/webtools/bugzilla/editparams.cgi,v  <--  editparams.cgi
new revision: 1.48; previous revision: 1.47
done
RCS file: /cvsroot/mozilla/webtools/bugzilla/extensions/example/code/config.pl,v
done
Checking in extensions/example/code/config.pl;
/cvsroot/mozilla/webtools/bugzilla/extensions/example/code/config.pl,v  <--  config.pl
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/webtools/bugzilla/extensions/example/lib/ConfigExample.pm,v
done
Checking in extensions/example/lib/ConfigExample.pm;
/cvsroot/mozilla/webtools/bugzilla/extensions/example/lib/ConfigExample.pm,v  <--  ConfigExample.pm
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/webtools/bugzilla/extensions/example/template/en/default/admin/params/example.html.tmpl,v
done
Checking in extensions/example/template/en/default/admin/params/example.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/extensions/example/template/en/default/admin/params/example.html.tmpl,v  <--  example.html.tmpl
initial revision: 1.1
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Updated

4 years ago
Blocks: 396244
You need to log in before you can comment on or make changes to this bug.