Closed Bug 430909 Opened 16 years ago Closed 16 years ago

Add hook for parameters

Categories

(Bugzilla :: Administration, task)

3.1.3
task
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 3.2

People

(Reporter: bbaetz, Assigned: bbaetz)

References

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
Extensions should be able to have their own parameters, via hooks.

Patch includes changes to the example plugin
Attachment #317819 - Flags: review?(mkanat)
  Since this is a hook, I'd like to see it in 3.2, but LpSolit has to agree.
Severity: normal → enhancement
Status: NEW → ASSIGNED
Component: Bugzilla-General → Administration
OS: Linux → All
Hardware: PC → All
Target Milestone: --- → Bugzilla 3.2
Comment on attachment 317819 [details] [diff] [review]
Patch

Looks good to me. This look good to you, LpSolit?
Attachment #317819 - Flags: review?(mkanat)
Attachment #317819 - Flags: review?(LpSolit)
Attachment #317819 - Flags: review+
Comment on attachment 317819 [details] [diff] [review]
Patch

>Index: Bugzilla/Config.pm

>+        my @new_param_list = "$module"->get_param_list();

Nit: quotes around $module are now useless AFAIK.



>Index: editparams.cgi

>+    my @module_param_list = "$module"->get_param_list(1);

Nit: same comment here.


>+    my @module_param_list = "$param_panels->{$current_module}"->get_param_list(1);

Nit: same comment here.


r=LpSolit with these useless quotes removed.
Attachment #317819 - Flags: review?(LpSolit) → review+
We are going to release 3.1.4. Maybe wait for the release before checking it in, in case we regress something.
Flags: approval?
Yeah, will wait
Bugzilla 3.1.4 has been released. You can now check it in.
Flags: approval? → approval+
Checked in:

Checking in Bugzilla/Config.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config.pm,v  <--  Config.pm
new revision: 1.74; previous revision: 1.73
done
Checking in editparams.cgi;
/cvsroot/mozilla/webtools/bugzilla/editparams.cgi,v  <--  editparams.cgi
new revision: 1.48; previous revision: 1.47
done
RCS file: /cvsroot/mozilla/webtools/bugzilla/extensions/example/code/config.pl,v
done
Checking in extensions/example/code/config.pl;
/cvsroot/mozilla/webtools/bugzilla/extensions/example/code/config.pl,v  <--  config.pl
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/webtools/bugzilla/extensions/example/lib/ConfigExample.pm,v
done
Checking in extensions/example/lib/ConfigExample.pm;
/cvsroot/mozilla/webtools/bugzilla/extensions/example/lib/ConfigExample.pm,v  <--  ConfigExample.pm
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/webtools/bugzilla/extensions/example/template/en/default/admin/params/example.html.tmpl,v
done
Checking in extensions/example/template/en/default/admin/params/example.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/extensions/example/template/en/default/admin/params/example.html.tmpl,v  <--  example.html.tmpl
initial revision: 1.1
done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Blocks: 396244
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: