430955 - jsfun.h uses JSArenaPool without needed typename

Status: RESOLVED FIXED

Description

[Mike Hommey [:glandium]]

Created attachment 317887 [details] [diff] [review]
patch

All is in the summary

Comment 1

[Brendan Eich [:brendan]]

Rather than over-include where there's only an opaque typename dependency, use struct JSArena in the C function prototype.

/be

Comment 2

[Mike Hommey [:glandium]]

Created attachment 317895 [details] [diff] [review]
patch

Like this?

Comment 3

[Brendan Eich [:brendan]]

Comment on attachment 317895 [details] [diff] [review]
patch

Looks good, can await js1.8src (after mozilla1.9/fx3), although it is harmless to take sooner.

/be

Comment 4

[Brendan Eich [:brendan]]

Mike, did this bite a private or "friend" app that #includes jsfun.h? Just curious what that is.

/be

Comment 5

[Mike Hommey [:glandium]]

A "friend" app: http://search.cpan.org/dist/JavaScript/

It had other problems, which I fixed with the following patch:
http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=5;filename=diff;att=1;bug=478064

Comment 6

[Reed Loden [:reed] (use needinfo?)]

Comment on attachment 317895 [details] [diff] [review]
patch

Simple one keyword addition patch that fixes a build issue for some users of the js engine.

Comment 7

[Damon Sicore (:damons)]

Comment on attachment 317895 [details] [diff] [review]
patch

a1.9+=damons

Comment 8

[Reed Loden [:reed] (use needinfo?)]

Hope I correctly resummarized this bug.

Checking in js/src/jsfun.h;
/cvsroot/mozilla/js/src/jsfun.h,v  <--  jsfun.h
new revision: 3.65; previous revision: 3.64
done