Closed
Bug 430955
Opened 16 years ago
Closed 16 years ago
jsfun.h uses JSArenaPool without needed typename
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla1.9
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file, 1 obsolete file)
513 bytes,
patch
|
brendan
:
review+
damons
:
approval1.9+
|
Details | Diff | Splinter Review |
All is in the summary
Attachment #317887 -
Flags: review?(shaver)
Comment 1•16 years ago
|
||
Rather than over-include where there's only an opaque typename dependency, use struct JSArena in the C function prototype. /be
Assignee | ||
Comment 2•16 years ago
|
||
Like this?
Attachment #317887 -
Attachment is obsolete: true
Attachment #317895 -
Flags: review?(brendan)
Attachment #317887 -
Flags: review?(shaver)
Comment 3•16 years ago
|
||
Comment on attachment 317895 [details] [diff] [review] patch Looks good, can await js1.8src (after mozilla1.9/fx3), although it is harmless to take sooner. /be
Attachment #317895 -
Flags: review?(brendan) → review+
Comment 4•16 years ago
|
||
Mike, did this bite a private or "friend" app that #includes jsfun.h? Just curious what that is. /be
Blocks: js1.8src
Assignee | ||
Comment 5•16 years ago
|
||
A "friend" app: http://search.cpan.org/dist/JavaScript/ It had other problems, which I fixed with the following patch: http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=5;filename=diff;att=1;bug=478064
Updated•16 years ago
|
Assignee: general → mh+mozilla
Comment 6•16 years ago
|
||
Comment on attachment 317895 [details] [diff] [review] patch Simple one keyword addition patch that fixes a build issue for some users of the js engine.
Attachment #317895 -
Flags: approval1.9?
Comment 7•16 years ago
|
||
Comment on attachment 317895 [details] [diff] [review] patch a1.9+=damons
Attachment #317895 -
Flags: approval1.9? → approval1.9+
Comment 8•16 years ago
|
||
Hope I correctly resummarized this bug. Checking in js/src/jsfun.h; /cvsroot/mozilla/js/src/jsfun.h,v <-- jsfun.h new revision: 3.65; previous revision: 3.64 done
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Summary: jsfun.h uses JSArenaPool without including jsarena.h → jsfun.h uses JSArenaPool without needed typename
Target Milestone: --- → mozilla1.9
Updated•16 years ago
|
Flags: in-testsuite-
Flags: in-litmus-
You need to log in
before you can comment on or make changes to this bug.
Description
•