cairo-quartz-font leaks CGFonts

RESOLVED FIXED

Status

()

P1
normal
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: stuart.morgan+bugzilla, Assigned: vlad)

Tracking

Trunk
x86
Mac OS X
Points:
---
Bug Flags:
blocking1.9 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
Running leaks against a trunk version of Camino, I'm seeing tens of thousands of leaked CGFonts originating from within core cairo code. From a quick look at cairo-quartz-font.c:
- cairo_quartz_font_face_create_for_atsu_font_id calls CGFontCreateWithPlatformfont without a corresponding CGFontRelease (and doesn't return cgFont; it becomes a member of the returned struct, but that has its own retain on it)
- _cairo_quartz_font_create_toy calls CGFontCreateWith{Font}Name without a corresponding CGFontRelease (again, the struct that cgFont becomes part of has its own retain)
Well that's silly.  Thanks for catching this!  Easy fix, I'll create a patch later on tonight when I get home.
Flags: blocking1.9+
Priority: -- → P1
Created attachment 318063 [details] [diff] [review]
patch from upstream

Patch to fix leaks from upstream.
Assignee: nobody → vladimir
Status: NEW → ASSIGNED
Attachment #318063 - Flags: review+
Attachment #318063 - Flags: approval1.9?
Comment on attachment 318063 [details] [diff] [review]
patch from upstream

a1.9+=damons
Attachment #318063 - Flags: approval1.9? → approval1.9+
Revision 410...
1 files updated, 0 files merged, 0 files removed, 0 files unresolved
Checking in gfx/cairo/cairo/src/cairo-quartz-font.c;
/cvsroot/mozilla/gfx/cairo/cairo/src/cairo-quartz-font.c,v  <--  cairo-quartz-font.c
new revision: 1.4; previous revision: 1.3
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.