431009 - Revamped page: Edit Add-on: Manage Versions and Files

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Justin Scott [:fligtar]]

New Manage Versions and Files page for the revamp.

Comment 1

[Justin Scott [:fligtar]]

No idea how I filed this in Facebook.

Comment 2

[Justin Scott [:fligtar]]

Attachment: screenshot of manage versions list, v1

First pass at the list of versions for an add-on. Clicking on a version goes to the edit page for that specific version (see next screenshot). Add New Version button will go to a page to add a new version. The Remove Version button only appears for versions without any files, and is to fix bug 373542.

Comment 3

[Justin Scott [:fligtar]]

Attachment: screenshot of editing a specific version, v1

First pass at editing a specific version.

The first box is a list of all files in this version. The Add New File button goes to a page to add a new file to this version, something that wasn't available before (you could only add files to new versions). Clicking on a file downloads/installs the file.

The second box is target applications. New feature is the ability to add and remove applications. Before, you could only change versions of existing apps in install.rdf.

Release notes - nothing new except it uses new translation box.

Approval info - displays info on when the status of each file was last changed (will make date prettier).

Comment 4

[Basil Hashem [:baz]]

Nice work fligtar, couple of small requests/clarifications:

- Are you removing the restriction of being able to upload the same numbered version if one already exists? Or is there a message that says you should delete it?
- I think we should add the status (Public, pending, sandbox'ed, etc...) on this page as well.
- Add ability to disable or send to sandbox
- For the version details page, can you make the text areas larger? Perhaps put a char count recommendation if you are trying to have devs keep it short. But, it's just to small right now
- Can we put a link to editor's review history? (I think it would be useful, we have it on the editor pages I believe).
- Should there be a minus(-) when there is only one app supported? Can you really add say
- Can you dynamically add support for a new app from this page? (e.g. add SeaMonkey support just by clicking "Add New Application")? Are you re-writing the install.rdf that is delivered?

Thanks.

Comment 5

[Justin Scott [:fligtar]]

(In reply to comment #4)
> Nice work fligtar, couple of small requests/clarifications:
> 
> - Are you removing the restriction of being able to upload the same numbered
> version if one already exists? Or is there a message that says you should
> delete it?
If you upload a file and the same version string already exists, it will be added to that version id.

> - I think we should add the status (Public, pending, sandbox'ed, etc...) on
> this page as well.
Versions don't have a status, only add-ons and files, which is why the status talks about the individual files in the version.

> - Add ability to disable or send to sandbox
OK

> - For the version details page, can you make the text areas larger? Perhaps put
> a char count recommendation if you are trying to have devs keep it short. But,
> it's just to small right now
OK

> - Can we put a link to editor's review history? (I think it would be useful, we
> have it on the editor pages I believe).
We can, but that history is currently pretty incomplete for a lot of add-ons. History from before remora is gone, trusted add-ons don't have any more entries, add-ons that were changed from the admin Add-ons Manager don't have it. So it just looks incomplete for only a couple versions to show up, if that.

> - Should there be a minus(-) when there is only one app supported? Can you
> really add say
It's not any different from there being minuses with 2 apps supported - the author could just remove both. I'll make sure there is at least one app supported at validation.

> - Can you dynamically add support for a new app from this page? (e.g. add
> SeaMonkey support just by clicking "Add New Application")? Are you re-writing
> the install.rdf that is delivered?
Adding a new application only adds it to the database which will show up on the display page and be present when the application checks AMO to see if it's compatible. I don't know if SeaMonkey does that or not.

Comment 6

[Justin Scott [:fligtar]]

(In reply to comment #4)
> - Add ability to disable or send to sandbox

After thinking about this more, I'm wondering how much it will be used. I can see the use for changing an add-on's status and that will be supported, but I'm wondering how many authors want to temporarily disable a single file. They would more likely either delete the file or upload a new file.

It's going to be technically more difficult than expected for this because we don't have a disabled flag for files like we do with add-ons. And to add one would require changes to every SQL statement that touches the files table, including versioncheck and other important stuff. We do have a DISABLED status, but that is for admin disabled and I don't think we want to mix the two.

So, is this really necessary?

Comment 7

[Justin Scott [:fligtar]]

It would be easy enough to allow moving to sandbox though, although I'm not clear on how one interacts with sandbox versions when the add-on is public.

Comment 8

[Basil Hashem [:baz]]

No not super necessary.

Comment 9

[Justin Scott [:fligtar]]

Attachment: screenshot of manage versions list, v2

Updated screenshots. Will blog these today if they look good.

Comment 10

[Justin Scott [:fligtar]]

Attachment: screenshot of editing a specific version, v2

Comment 11

[Basil Hashem [:baz]]

Quick question - in the attachment in comment 9, why are there "-" Remove options for only the last 3 entries? Is it due to the fact that the version has files on it?

Comment 12

[Justin Scott [:fligtar]]

The Remove button only shows up for "empty" versions that have no files. It's the chief complaint of bug 373542.

Comment 13

[Justin Scott [:fligtar]]

Working on backend for this page.

Comment 14

[Justin Scott [:fligtar]]

This bug has been fixed on the AMO 3.5 Developer Tools revamp branch and will go live when 3.5 is launched (date not currently set).

There is a staging site available here: http://remora-3.5.php5stage.mozilla.com/en-US/firefox/

Comment 15

[Andy Mutton]

Is it possible to add the option to edit the filename AMO gives the extension? Some of my users have problems updating my extension (Screengrab!) and I have a sneaking suspicion that it's because of the "!" in the filename.

Comment 16

[Justin Scott [:fligtar]]

Andy, please file another bug about that and I'll look into it. Exclamation points are supposed to be stripped from the file name, but there may be a problem with the regex.