Closed Bug 431124 Opened 16 years ago Closed 16 years ago

xpcshell test test_bug_395092.js fails on Thunderbird (head_download_manager.js requires "LICENSE" file, not "LICENSE.txt")

Categories

(Toolkit :: Downloads API, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

test_bug_395092.js fails when running against Thunderbird:

/Users/moztest/mozilla/hg/mozilla/tools/test-harness/xpcshell-simple/test_all.sh: line 111: 64452 Abort trap              NATIVE_TOPSRCDIR="$native_topsrcdir" TOPSRCDIR="$topsrcdir" $xpcshell -s $headfiles -f $t $tailfiles 2> $t.log 1>&2
FAIL
../../../../_tests/xpcshell-simple/test_dm/unit/test_bug_395092.js.log:
>>>>>>>
*** Throwing trying to get CurProcD
*** Throwing trying to get MozBinD
*** test pending
WARNING: NS_ENSURE_TRUE(docShellTreeItem) failed: file /Users/moztest/mozilla/hg/mozilla/mailnews/base/src/nsMsgContentPolicy.cpp, line 632
*** Throwing trying to get cachePDir
*** Throwing trying to get ProfLD
*** test pending
*** test finished
*** running event loop
observering dl-start
observering timer-callback
WARNING: NS_ENSURE_TRUE(docShellTreeItem) failed: file /Users/moztest/mozilla/hg/mozilla/mailnews/base/src/nsMsgContentPolicy.cpp, line 632
###!!! ASSERTION: attempted to open a new window with no WindowCreator: 'mWindowCreator', file /Users/moztest/mozilla/hg/mozilla/embedding/components/windowwatcher/src/nsWindowWatcher.cpp, line 648

I'm filing this to get it tracked. Not sure if this is a core or a Thunderbird specific problem yet. Will post more info when I have it.
Note: in release mode, this test just seems to hang.
I've now found the source of this bug; head_download_manager.js assumes that all applications/builds have a "LICENSE" file in their dist/bin directory. TB actually has a "LICENSE.txt" file (and for the record, Camino doesn't have either).

Therefore we need to find a solution that will be more common to all applications/builds or provide our own file.

I have a couple of ideas I'm currently trying out.
Assignee: bugzilla → nobody
Component: General → Download Manager
Product: Thunderbird → Firefox
QA Contact: general → download.manager
Version: unspecified → Trunk
Assignee: nobody → bugzilla
OS: Mac OS X → All
Hardware: PC → All
Summary: xpcshell test test_bug_395092.js fails on Thunderbird → xpcshell test test_bug_395092.js fails on Thunderbird (head_download_manager.js requires "LICENSE" file, not "LICENSE.txt")
Attached patch The fixSplinter Review
This drops a redundant variable, and changes the file to use to res/language.properties. This looks like its included in all standard builds, all download manager tests still pass on Firefox, and it fixes it for Thunderbird as well. Sunbird also carries on passing the tests that it currently passes (there are some Sunbird failures not relating to this bug).

Shawn, are you happy with this change? I couldn't see any negative impact on the existing tests.
Attachment #319266 - Flags: review?(sdwilsh)
Comment on attachment 319266 [details] [diff] [review]
The fix

>   var dl = dm.addDownload(nsIDownloadManager.DOWNLOAD_TYPE_DOWNLOAD,
>-                          createURI("http://localhost:4444/LICENSE"),
>+			  createURI("http://localhost:4444/res/language.properties"),
nit: tabs, and things to line up

r=sdwilsh otherwise
Attachment #319266 - Flags: review?(sdwilsh) → review+
Checked in with tabs -> spaces and line up corrected. Fixed.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Flags: in-testsuite+
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: