Revise calIItipTransport::defaultIdentity

RESOLVED FIXED in 1.0b1

Status

RESOLVED FIXED
11 years ago
7 years ago

People

(Reporter: Fallen, Assigned: martinschroeder)

Tracking

unspecified
1.0b1

Details

Attachments

(1 attachment)

(Reporter)

Description

11 years ago
(Followup from bug 428392 comment #27)


>     /**
>      * Default identity for me within this transport. For example, this is
>      * your default email address in Thunderbird.
>+     *
>+     * XXX This should probably go away, using the default identity is far
>+     * from practical. Only user right now is calUtils's sendItipInvitation
>      */
>     readonly attribute AUTF8String defaultIdentity;
Yeah, when sending an iTIP item we should probably ask the user what identity
to send the email from.  Note that this only has to be done when we generate a
REQUEST or PUBLISH ourselves (i.e. we are the organizer).  This is used as a
workaround for the fact that you can't set the organizer email address in the
event dialog.  However, there are some smart defaults or configuration settings
we could make so that the user could set up their preferred identity to use
when sending meeting requests.  Also, as long as our default behavior is to
show a compose dialog before sending, the user will have a chance to change the
Send From identity via that window.

Comment 1

11 years ago
Instead of asking the organizer each time he creates a new meeting request, you could let us specify the identity in each calendar's properties (and use Thunderbird's default identity unless the user changes it for certain calendars).

Comment 2

10 years ago
(In reply to comment #1)
Bug 431522 implements that.
Depends on: 431522

Comment 3

10 years ago
I think we could now suspend calIItipItem::defaultIdentity.

Comment 4

10 years ago
oops, calIItipTransport::defaultIdentity of course
(Assignee)

Updated

9 years ago
Assignee: nobody → mschroeder
(Assignee)

Comment 5

9 years ago
Created attachment 385655 [details] [diff] [review]
Patch v1

Removed defaultIdentity from the idl, the implementation from the CalDAV provider, and the getter from calItipEmailTransport.js.
Attachment #385655 - Flags: review?(philipp)
(Assignee)

Updated

9 years ago
Status: NEW → ASSIGNED

Updated

9 years ago
Attachment #385655 - Attachment is patch: true
Attachment #385655 - Attachment mime type: application/octet-stream → text/plain
(Reporter)

Updated

9 years ago
Attachment #385655 - Flags: review?(philipp) → review+
(Reporter)

Comment 6

9 years ago
Comment on attachment 385655 [details] [diff] [review]
Patch v1

r=philipp
(Assignee)

Comment 7

9 years ago
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/79e026ffda30>

-> FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0
(Reporter)

Comment 8

7 years ago
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.