431126 - Revise calIItipTransport::defaultIdentity

Status: RESOLVED FIXED

(Calendar :: E-mail based Scheduling (iTIP/iMIP), defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

(Followup from bug 428392 comment #27)


>     /**
>      * Default identity for me within this transport. For example, this is
>      * your default email address in Thunderbird.
>+     *
>+     * XXX This should probably go away, using the default identity is far
>+     * from practical. Only user right now is calUtils's sendItipInvitation
>      */
>     readonly attribute AUTF8String defaultIdentity;
Yeah, when sending an iTIP item we should probably ask the user what identity
to send the email from.  Note that this only has to be done when we generate a
REQUEST or PUBLISH ourselves (i.e. we are the organizer).  This is used as a
workaround for the fact that you can't set the organizer email address in the
event dialog.  However, there are some smart defaults or configuration settings
we could make so that the user could set up their preferred identity to use
when sending meeting requests.  Also, as long as our default behavior is to
show a compose dialog before sending, the user will have a chance to change the
Send From identity via that window.

Comment 1

[Pete Riley]

Instead of asking the organizer each time he creates a new meeting request, you could let us specify the identity in each calendar's properties (and use Thunderbird's default identity unless the user changes it for certain calendars).

Comment 2

[Daniel Boelzle [:dbo]]

(In reply to comment #1)
Bug 431522 implements that.

Comment 3

[Daniel Boelzle [:dbo]]

I think we could now suspend calIItipItem::defaultIdentity.

Comment 4

[Daniel Boelzle [:dbo]]

oops, calIItipTransport::defaultIdentity of course

Comment 5

[Martin Schröder [:mschroeder]]

Attachment: Patch v1

Removed defaultIdentity from the idl, the implementation from the CalDAV provider, and the getter from calItipEmailTransport.js.

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 385655 [details] [diff] [review]
Patch v1

r=philipp

Comment 7

[Martin Schröder [:mschroeder]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/79e026ffda30>

-> FIXED

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".