431535 - Static item's context menu in bookmark menu is messed up

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Damian Shaw [Quan]]

Attachment: Right click menu

1. Click on Bookmarks in the menu bar (between History and Tools)
2. Move mouse over the static "Bookmarks Toolbar" item
3. Right click on the static "Bookmarks Toolbar" item
4. Right click menu is a mess (see attached)


Made invalid by bug 429469 ?

Comment 1

[Damian Shaw [Quan]]

Clearing blocking for now, I suddenly found I could no longer duplicate it, testing on:

Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9pre) Gecko/2008042906 Minefield/3.0pre ID:2008042906

Will renom when I find a more reproducible STR.

Comment 2

[Damian Shaw [Quan]]

Aha, found the problem, here's a STR that has 100% duplication:

1. Close down all instances of Firefox
2. Open up Firefox
3. Right click on any static item in the bookmarks menu (accessed from the menubar)



Behavior changes when right clicking on a non-static item in the bookmarks menu

Renominating now I can dupe 100% and have found the cause of why I couldn't before.

Comment 3

[Marco Bonardo [:mak]]

Error: aNode is null
Source File: file:///C:/Users/MaK77/Desktop/minefield/modules/utils.js
Line: 388

Error: uncaught exception: [Exception... "'[JavaScript Error: "aNode is null" {file: "file:///C:/Users/MaK77/Desktop/minefield/modules/utils.js" line: 388}]' when calling method: [nsIController::isCommandEnabled]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: chrome://browser/content/places/controller.js :: updatePlacesCommand :: line 1490"  data: yes]
Source File: chrome://browser/content/places/menu.xml
Line: 898

can you look out for a regression window?

Comment 4

[Damian Shaw [Quan]]

Bug does NOT occur on:

Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9pre) Gecko/2008042705 Minefield/3.0pre ID:2008042705

Bug does occur on:

Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9pre) Gecko/2008042806 Minefield/3.0pre ID:2008042806

CVS check-ins in that time: http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&branch=HEAD&date=explicit&mindate=2008-04-27+05%3A00&maxdate=2008-04-28+06%3A00 (though I've never done a CVS search before, so double check I've got that right)

Comment 5

[Marco Bonardo [:mak]]

thank you, regressed in bug 428403, patch coming

Comment 6

[Marco Bonardo [:mak]]

Attachment: patch

directly check if we have a valid places node selected, if not we use the current selectedNode (since in that case selectedNode is our parent). this works also for special empty (and for static items clearly)

Comment 8

[Asaf Romano (gone)]

Comment on attachment 318610 [details] [diff] [review]
patch

r=mano

Comment 9

[Mike Connor [:mconnor]]

Comment on attachment 318610 [details] [diff] [review]
patch

a=mconnor on behalf of 1.9 drivers

Comment 10

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/places/content/menu.xml 	1.133
mozilla/browser/components/places/content/toolbar.xml 	1.155 

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Marco, the same happens when you click on an empty area within the Bookmarks Toolbar. Will this be also fixed with this patch?

Comment 12

[Marco Bonardo [:mak]]

yes, IIRC i've tested that too. it should work since in that zone you don't have a valid places node

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This fixes the context menu for the Bookmarks Menu and even the mentioned issues for the Bookmarks Toolbar.

Verified with:

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008050606 Minefield/3.0pre ID:2008050606

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008050619 Minefield/3.0pre

and on Ubuntu 8.04 with the same build.

Comment 14

[Aakash Desai [:aakashd]]

Test cases were updated on litmus FFt's for 3.x test runs. 

For 3.0,
https://litmus.mozilla.org/show_test.cgi?id=7599

For 3.1,
https://litmus.mozilla.org/show_test.cgi?id=7480

Comment 15

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv