431543 - Denying the opportunity of rendering public photos on spreadfirefox

Status: RESOLVED FIXED

(Websites Graveyard :: spreadfirefox.com, defect, P1)

Description

[Paul Booker]

Would you please review the attached patch which adds code to the flickr module to check for flickr users that should be denied the opportunity of rendering their tagged public photos on spreadfirefox

This patch would need to be pushed later with the  following table ..

CREATE TABLE `flickr_denied` (
  `nsid` varchar(64) NOT NULL
) ENGINE=MyISAM DEFAULT CHARSET=latin1;

Comment 1

[Paul Booker]

Attachment: flickr_block.module patch

Comment 2

[Alix Franquet [:alix]]

Does the patch let admins disable specific pictures or specific tags or both?

Comment 3

[Paul Booker]

It allows administrators to block a flickr user.

So if a spreadfirefox user posts something on flickr tagged with spreadfirefox that is inappropriate we can add the flickr id to the flickr_denied table and block the user from showing all images on spreadfirefox . 

What we have with this patch is the minimum required to solve the problem. When this is pushed i can work on extending this so we can block the image(s) only  and provide some GUI interface to handle all of this 

Paul Booker

Comment 4

[matthew zeier [:mrz]]

Over to webdev for review.

Comment 5

[Alex Polvi]

sorting it out...

Comment 6

[Chris Pollett]

Comment on attachment 318608 [details] [diff] [review]
flickr_block.module patch

patch looks good. tested it. Need to update database as indicated above to get this to work

Comment 7

[Alex Polvi]

Paul, please commit this. Do you have access to run the SQL on stage? If so, do that first, then commit the patch. If not, let me know.

After we deploy it to stage, we can ask IT to push it live.

Comment 8

[Paul Booker]

Alex , I have added the SQL statement with the patch and commited to subversion.

If we can get the changes pushed live ill take it from there.

Thanks Paul

Comment 9

[Paul Booker]

Attachment: flickr_block patch

Comment 10

[Chris Pollett]

Hi Paul,

I think you checked this in. Should we mark it as resolved?

Comment 11

[Paul Booker]

Hi Chris

I'll resolve this as bug fixed when the changes have been pushed to production
and i have updated the database successfully 

Thanks Paul 

Comment 12

[Paul Booker]

Hi Chris,

Has this patch been pushed to production and the database schema updated on the status report page ? If so would you close this ticket please.

Thanks Paul

Comment 13

[Alex Polvi]

yes, it has been pushed and the db is update.

Comment 14

[Paul Booker]

Thanks Alex :-)