Denying the opportunity of rendering public photos on spreadfirefox



11 years ago
8 years ago


(Reporter: paul, Assigned: cpollett)





(1 attachment, 1 obsolete attachment)



11 years ago
Would you please review the attached patch which adds code to the flickr module to check for flickr users that should be denied the opportunity of rendering their tagged public photos on spreadfirefox

This patch would need to be pushed later with the  following table ..

CREATE TABLE `flickr_denied` (
  `nsid` varchar(64) NOT NULL

Comment 1

11 years ago
Created attachment 318608 [details] [diff] [review]
flickr_block.module patch
Attachment #318608 - Flags: review?
Does the patch let admins disable specific pictures or specific tags or both?

Comment 3

11 years ago
It allows administrators to block a flickr user.

So if a spreadfirefox user posts something on flickr tagged with spreadfirefox that is inappropriate we can add the flickr id to the flickr_denied table and block the user from showing all images on spreadfirefox . 

What we have with this patch is the minimum required to solve the problem. When this is pushed i can work on extending this so we can block the image(s) only  and provide some GUI interface to handle all of this 

Paul Booker
Over to webdev for review.
Assignee: server-ops → nobody
Component: Server Operations → Webdev
QA Contact: justin → webdev

Comment 5

11 years ago
sorting it out...
Assignee: nobody → paul
Group: infra
Component: Webdev →
Priority: -- → P1
Product: → Websites
Version: other → unspecified


11 years ago
Attachment #318608 - Flags: review? → review?(cpollett)

Comment 6

11 years ago
Comment on attachment 318608 [details] [diff] [review]
flickr_block.module patch

patch looks good. tested it. Need to update database as indicated above to get this to work
Attachment #318608 - Flags: review?(cpollett) → review+

Comment 7

11 years ago
Paul, please commit this. Do you have access to run the SQL on stage? If so, do that first, then commit the patch. If not, let me know.

After we deploy it to stage, we can ask IT to push it live.

Comment 8

11 years ago
Alex , I have added the SQL statement with the patch and commited to subversion.

If we can get the changes pushed live ill take it from there.

Thanks Paul


Comment 9

11 years ago
Created attachment 318900 [details] [diff] [review]
flickr_block  patch
Attachment #318608 - Attachment is obsolete: true

Comment 10

11 years ago
Hi Paul,

I think you checked this in. Should we mark it as resolved?

Comment 11

11 years ago
Hi Chris

I'll resolve this as bug fixed when the changes have been pushed to production
and i have updated the database successfully 

Thanks Paul 


Comment 12

11 years ago
Hi Chris,

Has this patch been pushed to production and the database schema updated on the status report page ? If so would you close this ticket please.

Thanks Paul
Assignee: paul → cpollett

Comment 13

11 years ago
yes, it has been pushed and the db is update.
Last Resolved: 11 years ago
Resolution: --- → FIXED

Comment 14

11 years ago
Thanks Alex :-)
Product: Websites → Websites Graveyard
You need to log in before you can comment on or make changes to this bug.