431578 - "See All Versions" padded with a bit too much dead space around it

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Dave Garrett]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008042904 Minefield/3.0pre
Build Identifier: 

Currently we have the "see all versions" link (added in bug 425477) between the compatibility range(s) (added in bug 425539) and support section (added in bug 425510) with 2 blank lines on either side.  This looks a little out of place with the overall layout.  I suggest simply moving this link to the right of the compatibility range(s), as that has quite a bit of empty space to its side.  This would get rid of some of this odd new white space on the right that's been added with these two new features.

Not a drastic change mind you, but I think it looks a bit better without all that extra space.  At far least, those extra two blank lines around the link don't need to be there.

Reproducible: Always

Comment 1

[Dave Garrett]

Attachment: quick and lazy mockup of proposed layout change

Comment 2

[Dave Garrett]

This is a minor tweak, so it could theoretically be put in 3.4.1, but my guess is it'd really be marked for 3.4.2 if it was to be accepted.  Comments?

Comment 3

[Wil Clouser [:clouserw]]

(In reply to comment #2)
> This is a minor tweak, so it could theoretically be put in 3.4.1, but my guess
> is it'd really be marked for 3.4.2 if it was to be accepted.  Comments?
> 

Your guess is correct. :)

I like the idea - madhava, thoughts?

Comment 4

[Madhava Enros [:madhava]]

I like this idea too.  I definitely agree -- the current spacing looks a bit odd, but also gets in the way of people associating the two items as being related.

My only concern about moving the link to the far right is that people won't notice it as much when scanning down the page.  What about to the right of the text block, but not all the way over?  I'll attach a mockup

Comment 5

[Madhava Enros [:madhava]]

Attachment: possible link position

oh, I've made the link text a little smaller, too, so that it's not bigger than the section headers.

Comment 6

[Dave Garrett]

> oh, I've made the link text a little smaller, too, so that it's not bigger than
> the section headers.

Yeah, the text looks better like that.

I agree, that position looks good there too.  Though, I'd suggest centering it vertically along-side the "works with" box.  (would look odd if multiple ranges are shown, assuming that ever gets done)

If you're worried about it being easily noticed, you could give it a faint button appearance to make it stand out more.

Comment 7

[Wil Clouser [:clouserw]]

This seems like a pretty quick fix; dropping into 3.4.2 and assigning to cpollett.  If you don't have time, feel free to reassign to me.

Comment 8

[Chris Pollett]

Attachment: Patch to move link position as suggested

The changes to the helper with this patch are because I notice when viewing the page in hebrew (to check my patch works for an rtl language), I noticed this helper was generating warnings about something not being an array.

Comment 9

[Dave Garrett]

There's a lot of nothing changes in that diff.  (the first is whitespace, but I don't see anything on many of the others)  A bit hard to find the actual changes in there.  :/

Comment 10

[Chris Pollett]

Attachment: correct patch. oops.

Comment 11

[Chris Pollett]

Attachment: oops. forgot to assign anyone to review my last patch and has gone stale

Comment 12

[Michael Morgan [:morgamic]]

Comment on attachment 320635 [details] [diff] [review]
oops. forgot to assign anyone to review my last patch and has gone stale

Works for me.

Comment 13

[Chris Pollett]

checked in r13060

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; we vertically centered this intentionally (comment 6).

Comment 15

[Dave Garrett]

I thought we were going with the positioning and text size suggested in comment #5 by Madhava?  This aligns to the right and the size is unchanged.

https://preview.addons.mozilla.org/en-US/firefox/addon/5791

Comment 16

[Dave Garrett]

and comment #4 had the reasoning:
> My only concern about moving the link to the far right is that people won't
> notice it as much when scanning down the page.  What about to the right of the
> text block, but not all the way over?

This current patch just moves the link from one odd place to another.  (granted, it's better)  REOPENED requesting it be moved over and resized to resemble Madhava's mockup.  (attachment 318888 [details])

Comment 17

[Chris Pollett]

Attachment: okay. tried to duplicate what madhava had as exactly as I could

Comment 18

[Michael Morgan [:morgamic]]

Comment on attachment 320646 [details] [diff] [review]
okay. tried to duplicate what madhava had as exactly as I could

Also works for me.

Comment 19

[Chris Pollett]

checked into r13068

Comment 20

[Stephen Donner [:stephend] Not actively reading bugmail]

I think it looks slightly worse now, as the arrow graphic is clipped; still doesn't align correctly :-(

Comment 21

[Dave Garrett]

I hate to do this... but yeah, it's cutoff now.

REOPENED again.  :p

Text is a little bit better.  Could probably also be made bold.  Maybe just use the same CSS as the text for the download button?

Comment 22

[Chris Pollett]

Attachment: okay. I made it bold with a beautifully unclipped image

Comment 23

[Chris Pollett]

checked into r13089

Comment 24

[Dave Garrett]

Beautiful.  Let the nitpicking end.  :)

VERIFIED FIXED

Comment 25

[Dave Garrett]

Though... I am now noticing that that image is shown a couple pixels low...  I'm just saying...  :p