If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

custom bookmark keywords are repeated in search text

RESOLVED INCOMPLETE

Status

()

Firefox
Bookmarks & History
RESOLVED INCOMPLETE
10 years ago
8 years ago

People

(Reporter: David.Biesack, Unassigned)

Tracking

3.0 Branch
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

10 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5) Gecko/2008032620 Firefox/3.0b5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5) Gecko/2008032620 Firefox/3.0b5

Firefox comes with a built in 'google' search keyword. when you use it,
the keyword is included in the search phrase


Reproducible: Always

Steps to Reproduce:
1. type

  google firefox keyword search bookmark

in the address bar and press enter.


Actual Results:  
the keyword ("google" in this case) is included in
the search text %1 that is expanded. i.e. Firefox opens the URL

http://www.google.com/search?ie=UTF-8&oe=UTF-8&sourceid=navclient&gfns=1&q=google+firefox+keyword+search+bookmark



Expected Results:  
should go to

http://www.google.com/search?ie=UTF-8&oe=UTF-8&sourceid=navclient&gfns=1&q=firefox+keyword+search+bookmark

(no extra "google+")



This also happens for user defined search keywords; I defined a shorter bookmark with the keyword 'g'

http://www.google.com/search?q=%s

and when I type

   g firefox keyword search bookmark

I end up at the URL

   http://www.google.com/search?ie=UTF-8&oe=UTF-8&sourceid=navclient&gfns=1&q=g+firefox+keyword+search+bookmark

which should be

http://www.google.com/search?ie=UTF-8&oe=UTF-8&sourceid=navclient&gfns=1&q=firefox+keyword+search+bookmark

instead
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008050103 Minefield/3.0pre

I made a keyword on www.google.com, by right clicking on the field and choosing "Add a Keyword for this Search" and gave it the keyword google. Then I typed google internet in the locationbar and it did a Google search for internet.
So I can't reproduce the problem.
(Reporter)

Comment 2

10 years ago
I found that I had two bookmarks that both defined the "g" as a keyword.
although the url was the same.

when I deleted the duplicate, the keyword search worked as expected,
not adding "g" to the search term.

However, when I enter 

  google home depot

in the location bar, Firefox 3B5 is still expanding this to 

  http://www.google.com/search?ie=UTF-8&oe=UTF-8&sourceid=navclient&gfns=1&q=google+home+depot

instead of

  http://www.google.com/search?ie=UTF-8&oe=UTF-8&sourceid=navclient&gfns=1&q=home+depot

(Note: I do not get this problem when I enter the phrase in the search engine box to the right of the location bar when "Google" is selected.)

Updated

10 years ago
Component: Bookmarks → Places
QA Contact: bookmarks → places
Version: unspecified → 3.0 Branch

Comment 3

10 years ago
humm if the keyword is g why you add google? should not you enter "g home depot"?
Bulk closing all UNCONFIRMED bugs dealing with places that haven't had any bug activity in over 120 days, have no votes, and are not enhancement requests.

If you are still experiencing this issue in Firefox 3.0 or later, please re-open the bug with steps to reproduce (if they were not part of the original comment).
Status: UNCONFIRMED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → INCOMPLETE
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.