431606 - Content Drop-down menus should appear with the parent menu

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Nick Kreeger]

Attachment: Screen Shot

From the landing of fixes for bug 374570 and bug 374570, submenus can get drawn incorrectly for content popups.

This happens simply because the y pivot variable gets calculated for the screen-top-twips, rather than the screen-bottom-twips.

This patch affect Songbird since the library view is loaded (as a XUL content page) through the web view. This defect can be easily reproduced (with the attached testcase) for Firefox 3b5.

See attached screenshot.

Comment 1

[Nick Kreeger]

Attachment: Test Case

Here is the test-case, the |nsMenuPopupFrame| patch is coming next.

Comment 2

[Nick Kreeger]

Attachment: Patch V1

Here is the proposed patch - it simply calculates the y-pivot variable based on the bottom-screen-twip rather than the top-screen twip.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 318721 [details] [diff] [review]
Patch V1

Looks good to me. I think the patch in bug 84121 was just incorrect. It also changed ySpillage to use screenHeight instead of screenBottom, and that change has been reverted since.

Comment 4

[Nick Kreeger]

Asking for 1.9 approval please!

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 318721 [details] [diff] [review]
Patch V1

a1.9=beltzner

Comment 6

[Nick Kreeger]

(In reply to comment #5)
> (From update of attachment 318721 [details] [diff] [review])
> a1.9=beltzner 
> 

Thanks Beltzner! I'll land this tomorrow-ish...

Comment 7

[Nick Kreeger]

Checked into HEAD.. thanks roc, enn, and beltzner!

Comment 8

[Marcia Knous [:marcia]]

verified fixed using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008050506 Minefield/3.0pre as well as the Mac Leopard nightly. I verified using the testcase in the bug.