Closed
Bug 431606
Opened 17 years ago
Closed 17 years ago
Content Drop-down menus should appear with the parent menu
Categories
(Core :: Layout, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: nick.kreeger, Assigned: nick.kreeger)
Details
Attachments
(3 files)
|
59.25 KB,
image/png
|
Details | |
|
792 bytes,
application/vnd.mozilla.xul+xml
|
Details | |
|
1.28 KB,
patch
|
enndeakin
:
review+
roc
:
superreview+
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
Screen Shot
From the landing of fixes for bug 374570 and bug 374570, submenus can get drawn incorrectly for content popups.
This happens simply because the y pivot variable gets calculated for the screen-top-twips, rather than the screen-bottom-twips.
This patch affect Songbird since the library view is loaded (as a XUL content page) through the web view. This defect can be easily reproduced (with the attached testcase) for Firefox 3b5.
See attached screenshot.
|
Assignee | |
Comment 1•17 years ago
|
||
Here is the test-case, the |nsMenuPopupFrame| patch is coming next.
Assignee: nobody → nick.kreeger
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•17 years ago
|
||
Here is the proposed patch - it simply calculates the y-pivot variable based on the bottom-screen-twip rather than the top-screen twip.
|
|
Assignee | |
Updated•17 years ago
|
Attachment #318721 -
Flags: review?
Comment on attachment 318721 [details] [diff] [review]
Patch V1
Looks good to me. I think the patch in bug 84121 was just incorrect. It also changed ySpillage to use screenHeight instead of screenBottom, and that change has been reverted since.
Attachment #318721 -
Flags: superreview+
Attachment #318721 -
Flags: review?(enndeakin)
Attachment #318721 -
Flags: review?
|
||
Updated•17 years ago
|
Attachment #318721 -
Flags: review?(enndeakin) → review+
|
|
Assignee | |
Updated•17 years ago
|
Attachment #318721 -
Flags: approval1.9?
|
||
Comment 5•17 years ago
|
||
Comment on attachment 318721 [details] [diff] [review]
Patch V1
a1.9=beltzner
Attachment #318721 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Comment 6•17 years ago
|
||
(In reply to comment #5)
> (From update of attachment 318721 [details] [diff] [review])
> a1.9=beltzner
>
Thanks Beltzner! I'll land this tomorrow-ish...
|
|
Assignee | |
Comment 7•17 years ago
|
||
Checked into HEAD.. thanks roc, enn, and beltzner!
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Comment 8•17 years ago
|
||
verified fixed using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008050506 Minefield/3.0pre as well as the Mac Leopard nightly. I verified using the testcase in the bug.
Status: RESOLVED → VERIFIED
|
|
||
Updated•17 years ago
|
Flags: wanted1.9.0.x?
You need to log in
before you can comment on or make changes to this bug.
Description
•