Closed Bug 431620 Opened 12 years ago Closed 4 years ago

GetToggledKeyState is unused and should be removed

Categories

(Core :: Widget, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: roc, Assigned: mbrubeck)

Details

(Whiteboard: [good first bug])

Attachments

(1 file)

Whiteboard: [good first bug]
Ah. OK.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WONTFIX
Attached patch patchSplinter Review
This function is still unused, and there seem to be questions in bug 259059 about the best way to track the modifier state.  Should we remove this unused/untested code for now, and add it back only if it's needed?
Assignee: nobody → mbrubeck
Status: RESOLVED → REOPENED
Attachment #8688066 - Flags: review?(roc)
Resolution: WONTFIX → ---
Note: After this patch, `KeymapWrapper::AreModifiersCurrentlyActive` is also unused, except for this line which is inside of `#if 0`:

https://hg.mozilla.org/mozilla-central/file/a7f961230ac369373b03693e837372c1d0f6d589/widget/gtk/nsWindow.cpp#l1982

Should we remove AreModifiersCurrentlyActive too, along with this commented-out code?
Comment on attachment 8688066 [details] [diff] [review]
patch

Review of attachment 8688066 [details] [diff] [review]:
-----------------------------------------------------------------

Yes. Easy enough to add back if needed.
Attachment #8688066 - Flags: review?(roc) → review+
https://hg.mozilla.org/mozilla-central/rev/40ac57ab9a1b
Status: REOPENED → RESOLVED
Closed: 12 years ago4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.