431632 - Thunderbird doesn't need to ship addressbook-panel

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Phil Ringnalda (:philor)]

When bug 286806 moved our packaging of mailnews chrome out of mailnews/jar.mn, it missed an opportunity to not package addressbook-panel.xul and .js (the SeaMonkey sidebar panel), along with getting rid of some unused strings and probably some unneeded code (http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/mail/components/addrbook/content/abCommon.js&rev=1.29&mark=669-679#665 might conceivably work with the compose sidebar, maybe, except that gCurFrame isn't ever going to be defined for us).

Comment 1

[Phil Ringnalda (:philor)]

Attachment: Fix v.1

* The .xul and .js, we don't need because they are a browser sidebar (one which is currently broken for us, since nobody thought we even packaged it, so it has an entity in the .xul that isn't in our forked .dtd).

* The bit getting the ab view out of the sidebar has never done anything for us, since gCurFrame is only defined in the suite's sidebarOverlay.js.

* abMainWindow wasn't using any of those results pane context menu entities, because there isn't any results pane context menu, or anything I'd call a results pane in the main window.

* abResultsPane wasn't using them either, since, again, there isn't any results pane context menu, though it was including them in abContactsPanel, which was using just the Delete and Properties ones, and will be better off using them directly in its own .dtd

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 319338 [details] [diff] [review]
Fix v.1

Sure. r=mkmelin

Comment 3

[Phil Ringnalda (:philor)]

mail/components/addrbook/jar.mn 1.24
mail/components/addrbook/content/abCommon.js 1.31
mail/locales/en-US/chrome/messenger/addressbook/abContactsPanel.dtd 1.6
mail/locales/en-US/chrome/messenger/addressbook/abMainWindow.dtd 1.14
mail/locales/en-US/chrome/messenger/addressbook/abResultsPaneOverlay.dtd 1.4