Closed Bug 431639 Opened 16 years ago Closed 16 years ago

Library splitter should be styled the same as sidebar splitter

Categories

(Firefox :: Theme, defect)

x86
Windows XP
defect
Not set
trivial

Tracking

()

VERIFIED FIXED
Firefox 3

People

(Reporter: 427384, Assigned: mak)

References

Details

(Keywords: regression)

Attachments

(2 files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008043007 Minefield/3.0pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008043007 Minefield/3.0pre

The splitter in the Library should be in the same style as the sidebar. This seems to have been introduced as a result of Bug 403140.

Reproducible: Always
Blocks: 403140
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
Version: unspecified → Trunk
Attached patch patchSplinter Review
indeed it does not need a styling at all actually, the default is fine...

Was there a reason to ovveride them in previous Places impl?
also, we're setting a style for #splitter, But i don't see any instance of a splitter with id "splitter".

Dao?
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Attachment #319384 - Flags: review?(dao)
Comment on attachment 319384 [details] [diff] [review]
patch

yep, the default border styling from splitter.css is fine, and there's indeed no element with such an id.
Attachment #319384 - Flags: review?(dao)
Attachment #319384 - Flags: review+
Attachment #319384 - Flags: approval1.9?
Comment on attachment 319384 [details] [diff] [review]
patch

a1.9=beltzner
Attachment #319384 - Flags: approval1.9? → approval1.9+
mozilla/browser/themes/gnomestripe/browser/places/organizer.css 	1.18
mozilla/browser/themes/pinstripe/browser/places/organizer.css 	1.16
mozilla/browser/themes/winstripe/browser/places/organizer.css 	1.16 
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3
Verified with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008050606 Minefield/3.0pre ID:2008050606
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: