431671 - Can still remove root folders shortcuts using Cut

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Marco Bonardo [:mak]]

you cannot delete root folder shortcuts with normal Del or context, but you can still delete them with CTRL-X (cut), that should not be allowed since we don't allow it in other cases.

Comment 1

[Dietrich Ayala (:dietrich)]

drivers: this needs to block.

some info from https://bugzilla.mozilla.org/show_bug.cgi?id=423515#c20

"- even if cmd_cut is not enabled, and returns false, cuts via kb shortcut are
still allowed (!)"

Comment 2

[Dietrich Ayala (:dietrich)]

setting severity to major, this is a footgun.

Comment 3

[Dietrich Ayala (:dietrich)]

hrm, the command updating infrastructure is working properly (and this is evidenced by "cut" being disabled in the context menu.

maybe this problem is due to key hell (bug 429510)?

asking for qawanted, would be great to get a regression range.

Comment 4

[Dietrich Ayala (:dietrich)]

Attachment: wallpaper

could take this for wallpaper if necessary

Comment 5

[Asaf Romano (gone)]

Comment on attachment 318860 [details] [diff] [review]
wallpaper

I think we should have a check like this either way, but in remove(), then cut would just buggily-copy and we'll fix command updating later.

Comment 6

[Dietrich Ayala (:dietrich)]

Attachment: v2

Comment 7

[Asaf Romano (gone)]

Comment on attachment 318904 [details] [diff] [review]
v2

r=mano

Comment 8

[Marco Bonardo [:mak]]

Comment on attachment 318904 [details] [diff] [review]
v2

asking approval, this wallpaper is needed to avoid Library leftpane corruption

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 318904 [details] [diff] [review]
v2

a1.9=beltzner

Comment 10

[Dietrich Ayala (:dietrich)]

Checking in browser/components/places/content/controller.js;
/cvsroot/mozilla/browser/components/places/content/controller.js,v  <--  controller.js
new revision: 1.235; previous revision: 1.234
done

Comment 11

[Al Billings [:abillings - ex-MoCo]]

Verified in Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008050404 Minefield/3.0pre. 

Comment 12

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv