431706 - Remove aaa: namespacing for aria stuff in XUL files of ChatZilla

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Marco Zehe (:MarcoZ)]

There are still some aaa: attributes that no longer work since bug 398910 was fixed, which changed all ARIA namespacing to no longer be accepted. Instead, aria- should be used, also in XUL.

Comment 1

[:Gijs (he/him)]

Attachment: Patch

Like this?

Comment 2

[Marco Zehe (:MarcoZ)]

Comment on attachment 318848 [details] [diff] [review]
Patch

r=me. Thanks!

Comment 3

[James Ross]

Comment on attachment 318848 [details] [diff] [review]
Patch

r=silver so long as there's no released platform that needs the namespace (I'm thinking Firefox 2 here, but dunno when this Aria stuff appeared).

Comment 4

[alexander :surkov (:asurkov)]

(In reply to comment #3)
> (From update of attachment 318848 [details] [diff] [review])
> r=silver so long as there's no released platform that needs the namespace (I'm
> thinking Firefox 2 here, but dunno when this Aria stuff appeared).
> 

There is ARIA support in Firefox2. There namespaces were used. In Firefox3 ARIA doesn't have namespaces.

Comment 5

[James Ross]

Comment on attachment 318848 [details] [diff] [review]
Patch

In that case, this isn't the right patch. We need to keep the namespaced attributes for FF2.

Comment 6

[:Gijs (he/him)]

Attachment: Better patch

Alright, this should work, I believe.

Comment 7

[Marco Zehe (:MarcoZ)]

Comment on attachment 319018 [details] [diff] [review]
Better patch

Yeah, guess we don't have any other way right now.

Comment 8

[James Ross]

Comment on attachment 319018 [details] [diff] [review]
Better patch

Such is the fun of supporting multiple versions of a platform. :)

Comment 9

[:Gijs (he/him)]

Checking in mozilla/extensions/irc/xul/content/chatzilla.xul;
/cvsroot/mozilla/extensions/irc/xul/content/chatzilla.xul,v  <--  chatzilla.xul
new revision: 1.74; previous revision: 1.73
done