Remove aaa: namespacing for aria stuff in XUL files of ChatZilla

RESOLVED FIXED

Status

Other Applications
ChatZilla
--
trivial
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: MarcoZ, Assigned: Gijs)

Tracking

(Blocks: 1 bug, {access})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [cz-0.9.82])

Attachments

(1 attachment, 1 obsolete attachment)

1.11 KB, patch
James Ross
: review+
MarcoZ
: review+
Details | Diff | Splinter Review
(Reporter)

Description

10 years ago
There are still some aaa: attributes that no longer work since bug 398910 was fixed, which changed all ARIA namespacing to no longer be accepted. Instead, aria- should be used, also in XUL.
(Assignee)

Updated

10 years ago
Blocks: 370759
(Assignee)

Comment 1

10 years ago
Created attachment 318848 [details] [diff] [review]
Patch

Like this?
Attachment #318848 - Flags: review?(silver)
(Assignee)

Updated

10 years ago
Attachment #318848 - Flags: review?(marco.zehe)
(Assignee)

Updated

10 years ago
Status: NEW → ASSIGNED
(Reporter)

Comment 2

10 years ago
Comment on attachment 318848 [details] [diff] [review]
Patch

r=me. Thanks!
Attachment #318848 - Flags: review?(marco.zehe) → review+

Comment 3

10 years ago
Comment on attachment 318848 [details] [diff] [review]
Patch

r=silver so long as there's no released platform that needs the namespace (I'm thinking Firefox 2 here, but dunno when this Aria stuff appeared).
Attachment #318848 - Flags: review?(silver) → review+

Comment 4

10 years ago
(In reply to comment #3)
> (From update of attachment 318848 [details] [diff] [review])
> r=silver so long as there's no released platform that needs the namespace (I'm
> thinking Firefox 2 here, but dunno when this Aria stuff appeared).
> 

There is ARIA support in Firefox2. There namespaces were used. In Firefox3 ARIA doesn't have namespaces.

Comment 5

10 years ago
Comment on attachment 318848 [details] [diff] [review]
Patch

In that case, this isn't the right patch. We need to keep the namespaced attributes for FF2.
Attachment #318848 - Flags: review+ → review-
(Assignee)

Comment 6

10 years ago
Created attachment 319018 [details] [diff] [review]
Better patch

Alright, this should work, I believe.
Attachment #318848 - Attachment is obsolete: true
Attachment #319018 - Flags: review?(silver)
(Assignee)

Updated

10 years ago
Attachment #319018 - Flags: review?(marco.zehe)
(Reporter)

Comment 7

10 years ago
Comment on attachment 319018 [details] [diff] [review]
Better patch

Yeah, guess we don't have any other way right now.
Attachment #319018 - Flags: review?(marco.zehe) → review+

Comment 8

10 years ago
Comment on attachment 319018 [details] [diff] [review]
Better patch

Such is the fun of supporting multiple versions of a platform. :)
Attachment #319018 - Flags: review?(silver) → review+
(Assignee)

Comment 9

10 years ago
Checking in mozilla/extensions/irc/xul/content/chatzilla.xul;
/cvsroot/mozilla/extensions/irc/xul/content/chatzilla.xul,v  <--  chatzilla.xul
new revision: 1.74; previous revision: 1.73
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Whiteboard: [cz-0.9.82]
You need to log in before you can comment on or make changes to this bug.