Last Comment Bug 431721 - email_in.pl should automatically set @confirm_product_change = 1 when @product is defined
: email_in.pl should automatically set @confirm_product_change = 1 when @produc...
Status: RESOLVED FIXED
[Bugzilla 3.0.x only][tip not affected]
:
Product: Bugzilla
Classification: Server Software
Component: Incoming Email (show other bugs)
: 3.0.3
: All All
: -- normal (vote)
: Bugzilla 3.0
Assigned To: Frédéric Buclin
: default-qa
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-05-01 11:47 PDT by Frédéric Buclin
Modified: 2008-05-01 13:13 PDT (History)
1 user (show)
mkanat: approval3.0+
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch, v1 (681 bytes, patch)
2008-05-01 11:47 PDT, Frédéric Buclin
mkanat: review+
Details | Diff | Splinter Review

Description Frédéric Buclin 2008-05-01 11:47:22 PDT
Created attachment 318859 [details] [diff] [review]
patch, v1

In Bugzilla 3.0, when you want to move an existing bug into a new product, specifying @product has no effect, and no email is sent back to the sender. The reason is that process_bug.cgi displays the intermediate page to ask for confirmation. email_in.pl should automatically confirm the change for us.

In Bugzilla 3.2, this intermediate page is already skipped when called from email_in.pl. So this bug is about 3.0 only.
Comment 1 Max Kanat-Alexander 2008-05-01 12:52:01 PDT
  It's supposed to be automatically skipped in USAGE_MODE_EMAIL in Bugzilla 3.0. Did you check process_bug to see why it's not being skipped?
Comment 2 Max Kanat-Alexander 2008-05-01 13:07:54 PDT
Comment on attachment 318859 [details] [diff] [review]
patch, v1

Okay, this is the best change, and LpSolit said on IRC that he checked and process_bug doesn't do it right for 3.0, so we can take this.
Comment 3 Frédéric Buclin 2008-05-01 13:13:48 PDT
Checking in email_in.pl;
/cvsroot/mozilla/webtools/bugzilla/email_in.pl,v  <--  email_in.pl
new revision: 1.5.2.10; previous revision: 1.5.2.9
done

Note You need to log in before you can comment on or make changes to this bug.