431729 - Clear Private Data - 'Browsing History' deletes 'Download History' too

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Marcia Knous [:marcia]]

I got this one from hendrix and I confirmed it using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008050104 Minefield/3.0pre

STR: 
 1.load
http://www.mozilla.org/projects/minefield/minefield-icon.png
 2. right click - Save Image As - save to desktop
 3. show Downloads manager window
 4. you will see 'Download History'[download file
information ('minefield-icon.png','14.8 KB',etc.)]
 5. select Tools-Clear Private Data
 6. you will see Clear Private Data window
 7. check 'Browsing History' (default)
 7. uncheck 'Download History'
 8. click  'Clear Private Data Now' button
 9. show Downloads manager window again
10. I can't see 'Download History'[download file
information] anymore.

Browser Details: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008050105 Minefield/3.0pre

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

This is obviously caused by the auto-aging patch.

Mardak, is there any way to have the aging patch ignore deletes that come from the operation that deletes all history? If not, I think this ends up being another vote to back out that patch, as painful as that is.

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

19:06 <@beltzner> well, it's that or remove the clear download history from CPD
...
19:07 <@beltzner> I suppose the more correct fix would be to indent "Clear
                  Download History"
19:07 <@beltzner> and make it subordinate to "Clear History"
19:08 <@beltzner> and if "Clear History" is checked, then "Clear Download
                  History" would be inactive

(subordinate means indented!)

Comment 3

[Ed Lee :Mardak]

Attachment: v1

Shawn suggested that we include clear history in the aging bug 251337. If this behavior is undesired, suppose I should also point out that the aging bug also made it so if you deleted download entries from the Library, it would delete the item from the Download Manager.

If we also remove that, those downloads won't necessarily disappear from the download manager due to aging because those pages wouldn't exist in places anymore.

Comment 4

[Shawn Wilsher :sdwilsh]

Comment on attachment 318966 [details] [diff] [review]
v1

beltzner indicated the other solution in comment 2 ;)

Comment 5

[Ed Lee :Mardak]

Mm.. Is the button supposed to be inactive/disabled and automatically checked?

If it's subordinate, it would seem like you should be able to uncheck it and clear history without clearing downloads.

Kinda like those packed installers..

[+] Mozilla stuff (all)
 \ [+] Firefox
 \ [+] Thunderbird

[x] Mozilla Stuff (some)
 \ [-] Firefox
 \ [+] Thunderbird

Comment 6

[Shawn Wilsher :sdwilsh]

forgot to mention - I'm taking this back ;)

Comment 7

[Ed Lee :Mardak]

Sounds good. ;) I couldn't figure out how to examine the window with domI and minimizing the CPD popup has strange behavior on windows and mac.. :p

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

(In reply to comment #5)
> Mm.. Is the button supposed to be inactive/disabled and automatically checked?

Yeah, I'm just going for minimal invasiveness without being able to create new strings.

The ideal would be:

[ ] Clear Browsing History
  [ ] Visited websites
  [ ] Downloaded files

but that's a new string :(

[ ] Browsing History
  [ ] Download History

clearing browsing history implies download history, but not vice versa.

Comment 9

[Shawn Wilsher :sdwilsh]

Attachment: v2.0

Comment 10

[Shawn Wilsher :sdwilsh]

Attachment: v2.1

addresses comments over irc

Comment 11

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 319070 [details] [diff] [review]
v2.1

[02 16:41:22] <gavin_> sdwilsh: nit: use s.canClearItem("downloads")
[02 16:41:28] <gavin_> sdwilsh: nit: spell "sanitize" correctly in the filename

Comment 12

[Shawn Wilsher :sdwilsh]

Attachment: v2.2

Addresses review comments

Comment 13

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 319072 [details] [diff] [review]
v2.2

a=drivers for 1.9, thanks!

Comment 14

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/base/content/sanitize.xul 	1.17
mozilla/browser/base/content/test/Makefile.in 	1.21
mozilla/browser/base/content/test/browser_sanitize-download-history.js 	1.1 

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

Reopening; I've been testing a tinderbox build with ID: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9pre) Gecko/2008050522 Minefield/3.0pre build, and here's a really simple way repro case:

1. In "Privacy", "Private Data", "Settings", uncheck "Download History"
2. Download something
3. Tools | Clear Private Data -- notice "Download History" is _unchecked_ but /bolded/
4. Click "Clear Private Data Now"

Expected Results:

No download history is deleted

Actual Results:

All completed/failed/cancelled download history is deleted

In step #3, if download history data *is* to be deleted, it should be checked; being bolded just means the pref is toggle-able.

Comment 16

[:Gavin Sharp [email: [e-mail]]]

Filed bug 432427 for that, trying to keep track of landing multiple patches per bug just leads to trouble.

Comment 17

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9pre) Gecko/2008050804 Minefield/3.0pre

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008050806 Minefield/3.0pre

-and-

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008050804 Minefield/3.0pre

Comment 18

[Stephen Donner [:stephend] Not actively reading bugmail]

in-litmus+:

https://litmus.mozilla.org/show_test.cgi?id=5343

Comment 19

[Martin Pochert]

In SM 2.2 i have double and misleading preferences and the same bug:
1st Edit / Preferences / browser / Downloads / remove Download-List: never
2nd Edit / Preferences / Privacy & Security / always clear private data when I close SM: checked; download History: not checked
regards
Martin