431754 - try harder to commit in the face of safebrowsing server errors

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[Dave Camp (:dcamp)]

Attachment: v1

Right now it's common to hit a 400 error when processing safebrowsing redirects.  Currently we throw away the whole update when that happens, but in most cases we can apply what we've already received, which should be a big help on large updates.

Attached patch commits on a fetch failure, as long as we haven't started to process the data on the connection (in which case committing would leave us in an inconsistent state).

Comment 1

[Dave Camp (:dcamp)]

This patch also happens to fix 425570.

Comment 2

[Tony Chang (Google)]

Comment on attachment 318890 [details] [diff] [review]
v1

looks good.

Comment 3

[Damon Sicore (:damons)]

Comment on attachment 318890 [details] [diff] [review]
v1

a1.9+=damons

Comment 4

[Reed Loden [:reed]]

Checking in toolkit/components/url-classifier/src/nsUrlClassifierStreamUpdater.cpp;
/cvsroot/mozilla/toolkit/components/url-classifier/src/nsUrlClassifierStreamUpdater.cpp,v  <--  nsUrlClassifierStreamUpdater.cpp
new revision: 1.22; previous revision: 1.21
done
Checking in toolkit/components/url-classifier/src/nsUrlClassifierStreamUpdater.h;
/cvsroot/mozilla/toolkit/components/url-classifier/src/nsUrlClassifierStreamUpdater.h,v  <--  nsUrlClassifierStreamUpdater.h
new revision: 1.15; previous revision: 1.14
done

Comment 5

[Evan Yan]

Attachment: fix Solaris bustage

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Ports/1209899040.1209899142.610.gz

Sun CC is unhappy:

"../../../../../mozilla/toolkit/components/url-classifier/src/nsUrlClassifierStreamUpdater.cpp", line 311: Error: Ambiguous "?:" expression, second operand of type "int" and third operand of type "nsCOMPtr<nsIUrlClassifierCallback>" can be converted to one another.
"../../../../../mozilla/toolkit/components/url-classifier/src/nsUrlClassifierStreamUpdater.cpp", line 329: Error: Ambiguous "?:" expression, second operand of type "int" and third operand of type "nsCOMPtr<nsIUrlClassifierCallback>" can be converted to one another.
2 Error(s) detected.
gmake[5]: *** [nsUrlClassifierStreamUpdater.o] Error 2

Comment 6

[Reed Loden [:reed]]

Comment on attachment 319263 [details] [diff] [review]
fix Solaris bustage

There's already a patch for this in bug 432066.