431828 - Page with ARGB32 gif images scrolling/painting is slow.

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Widget: Qt, defect)

Description

[Oleg Romashin (:romaxa)]

Original source is CNN.com.

Optimized image surface for ARGB32 gif not created, and image draw happen with slow path (fillPath)....

I think we should use drawPixmap or drawImage, for painting animated gif frames.

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: oprofile data

Comment 2

[Oleg Romashin (:romaxa)]

I guess we have to create mQPainterSurface in nsThebesImage class....
And implement the same stuff as in bugs:
Bug 414685  and Bug 343655

Comment 3

[Oleg Romashin (:romaxa)]

Attachment: Possible fix....

Vlad can you check this way to fix this bug?

Comment 4

[Oleg Romashin (:romaxa)]

Attachment: Removed check in GetImageSurface which prevent to get ImageSurface

Comment 5

[Oleg Romashin (:romaxa)]

Comment on attachment 319026 [details] [diff] [review]
Removed check in GetImageSurface which prevent to get ImageSurface

hmm.. this approach eat too much memory...

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Yes, that duplicates each image as a pixmap; we don't optimize gif image frames because they normally are only used once, but we could be smarter about that for gifs with a small number of frames (including 1).

Comment 7

[Benjamin Smedberg]

In bug 1282866, I have removed the QT code from the Firefox tree with the approval of the active peer. That code is not currently maintained by any team.

I have looked through the bugs in the Widget: Qt bugzilla component and I believe all of these are no longer relevant because the Qt code has been removed. If you believe that this bug is still valid, please move it to another more appropriate bugzilla component as you reopen it.