431855 - user/register page generates error message and brings user to main home

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[/\/\arcio Galli]

Try register, 

it wil; generate a flash with something like 

"there are errors in this form... "

and will redirect you to amo home.  

Sorry could not find a dup in the DB or known issue reference.

Comment 1

[Laura Thomson :laura]

Is this a regression with 3.4.1?

Comment 2

[Basil Hashem [:baz]]

It appears to be critical. Just a clarification, it actually does create the new user in the process. I was able to login with my new id.

Comment 3

[Wil Clouser [:clouserw]]

This is caused by the patch in bug 427974

Comment 4

[Wil Clouser [:clouserw]]

Attachment: remove csrf from registration form

Similar to the log in form, the register form doesn't need CSRF checks.

Comment 5

[Chris Pollett]

Laura's reviewing it, but the modification in your patch seems reasonable to me.

Comment 6

[Wil Clouser [:clouserw]]

Comment on attachment 319031 [details] [diff] [review]
remove csrf from registration form

Ah, was hoping you'd come around.  You can review too. :)

Comment 7

[Laura Thomson :laura]

Comment on attachment 319031 [details] [diff] [review]
remove csrf from registration form

WFM

Comment 8

[Wil Clouser [:clouserw]]

Thanks, r12785

Comment 9

[Chris Pollett]

Comment on attachment 319031 [details] [diff] [review]
remove csrf from registration form

Cool

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; this has been tested by both Basil and me in production.