431870 - Dragging-and-dropping live bookmark item will duplicate it (don't allow dropping into readonly containers)

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Radek 'sysKin' Czyz]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008050206 Firefox/3.0pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008050206 Minefiled/3.0pre

It is possible to drag a live bookmark item and drop it to the same live bookmark folder. This will duplicate the item.


Reproducible: Always

Steps to Reproduce:
1. Subscribe to a live bookmark
2. Open the live folder, drag one item and drop it elsewhere in the same live folder.

Actual Results:  
The item duplicates.


Expected Results:  
Nothing can be dropped into a live folder, ever.


Live folders are "protected" from having anything dropped into them by never opening. But in this case, a live folder is already opened so "protection" doesn't work.

You can also duplicate fake "Live bookmark failed to load" item this way.

Comment 1

[(mostly gone) XtC4UaLL [:xtc4uall]]

confirmed, maybe related to Bug 431882 ?
Fx2 behavior is: feed item itself seems drop-/moveable, but there's no action. in case of bookmark item trying to be dropped there's the 'forbidden'-sign.

Comment 2

[Marco Bonardo [:mak]]

fixed by patch in bug 418671

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b1pre) Gecko/20080920033605 Minefield/3.1b1pre

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

As Marco pointed out on IRC we don't have d&d tests yet. Means, we should add this d&d behavior as a testcase on Litmus.

Comment 5

[Aakash Desai [:aakashd]]

verified FIXED on build: 

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3) Gecko/20090304 Firefox/3.1b3 ID:20090304233338

Added an in-testsuite? flag to ask if an mochitest case is needed for this case.

Comment 6

[Aakash Desai [:aakashd]]

Test case https://litmus.mozilla.org/show_test.cgi?id=7610 was created on litmus for regression testing in the 3.1 test run.

Comment 8

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv