Tb 2.0.0.14 Talkback drop has extra, Mac OS files in it

RESOLVED FIXED

Status

Release Engineering
General
P2
normal
RESOLVED FIXED
10 years ago
4 years ago

People

(Reporter: preed, Assigned: nthomas)

Tracking

({fixed1.8.1.15, fixed1.8.1.17})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
I got my automagical update to 2.0.0.14 today, and I started via the commandline on Linux; I saw:

libxpt: bad magic header in input file; found '', expected 'XPCOM\nTypeLi\r\n\032'
libxpt: bad magic header in input file; found '', expected 'XPCOM\nTypeLi\r\n\032'
libxpt: bad magic header in input file; found '', expected 'XPCOM\nTypeLi\r\n\032'

I've been starting Tb from the commandline on this machine (Ubuntu 64-bit) ever since I've had it, and never seen these errors.

I'll try it with 2.0.0.12 today, and see if it has the error.

I haven't seen any functionality that's broken or affected, but... depending on the xpt files that may be bad (?), it could be a lurking surprise.
(Reporter)

Comment 1

10 years ago
Not seeing this on Tb 2.0.0.9 (which I already had downloaded); I'll try 2.0.0.12 in a moment.
(Reporter)

Comment 2

10 years ago
I think I figured out the problem here; it looks like the last time the talkback bundles were packaged, a bunch of Mac OS attribute files were included with the drop:

./._talkback@mozilla.org
./talkback@mozilla.org/._chrome.manifest
./talkback@mozilla.org/components/._qfaservices.xpt
./talkback@mozilla.org/components/talkback/._master.ini
./talkback@mozilla.org/components/talkback/._talkback.so
./talkback@mozilla.org/components/talkback/._talkback
./talkback@mozilla.org/components/talkback/._XTalkback.ad
./talkback@mozilla.org/components/._talkback
./talkback@mozilla.org/components/._libqfaservices.so
./talkback@mozilla.org/._components

If you run strings on any of these files, you'll see:

Mac OS X        
ATTR
com.apple.quarantine
q/0000;47aa1bca;Minefield.app;|org.mozilla.firefox

The problem here is the XPT linker is finding ./talkback@mozilla.org/components/._qfaservices.xpt, but it's not an xpt file, so it's bucket of fail.

Looks like those talkback bundles need to be redone to pull these files out (and these files added to removedfiles for automatic update?)
(Reporter)

Updated

10 years ago
Summary: Tb 2.0.0.14 has libxpt warnings on startup → Tb 2.0.0.14 Talkback drop has extra, Mac OS files in it
(Reporter)

Comment 3

10 years ago
Bug 403701 has some info on this.
(Assignee)

Comment 4

10 years ago
Thanks for catching this Paul, going to test the fix on staging.
Component: General → Release Engineering
Priority: -- → P2
Product: Thunderbird → mozilla.org
QA Contact: general → release
Version: 2.0 → other
(Assignee)

Updated

10 years ago
Assignee: nobody → nrthomas
(Assignee)

Comment 5

10 years ago
Turns out Firefox avoids this problem by having a packages-static for both windows and linux which mostly includes specific files, and where it does a * wildcard that doesn't match files beginning with ".". Thunderbird only has a packages-static for windows. :-S

Anyway, I copied 
 /builds/tinderbox/talkback-thunderbird-1.8-linux.tar.bz2
to 
 /builds/tinderbox/old-talkback/
and fixed up the original file. Forcing a nightly to make sure it removes the files properly on an update.
(Assignee)

Comment 6

10 years ago
From updates/last-update.log when updating from 2008061303 to 2008061305:

EXECUTE REMOVE extensions/._talkback@mozilla.org
EXECUTE REMOVE extensions/talkback@mozilla.org/._chrome.manifest
EXECUTE REMOVE extensions/talkback@mozilla.org/._components
EXECUTE REMOVE extensions/talkback@mozilla.org/components/._libqfaservices.so
EXECUTE REMOVE extensions/talkback@mozilla.org/components/._qfaservices.xpt
EXECUTE REMOVE extensions/talkback@mozilla.org/components/._talkback
EXECUTE REMOVE extensions/talkback@mozilla.org/components/talkback/._XTalkback.ad
EXECUTE REMOVE extensions/talkback@mozilla.org/components/talkback/._master.ini
EXECUTE REMOVE extensions/talkback@mozilla.org/components/talkback/._talkback
EXECUTE REMOVE extensions/talkback@mozilla.org/components/talkback/._talkback.so

So that's fine for the partial update case.
(Assignee)

Comment 7

10 years ago
(In reply to comment #5)
> Anyway, I copied 
>  /builds/tinderbox/talkback-thunderbird-1.8-linux.tar.bz2
> to 
>  /builds/tinderbox/old-talkback/
> and fixed up the original file. Forcing a nightly to make sure it removes the
> files properly on an update.

On crazyhorse, that is. 

(Assignee)

Comment 8

10 years ago
Created attachment 324951 [details] [diff] [review]
Remove errant files on Linux

This'll make sure we remove them for both partial and complete updates.
Attachment #324951 - Flags: review?(ted.mielczarek)
Attachment #324951 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 9

10 years ago
Comment on attachment 324951 [details] [diff] [review]
Remove errant files on Linux

drivers, requesting approval to land this, ideally on both the 1.8 branch and the relbranch for Tb2.0.0.15. It isn't a serious bug but the fix is self-contained and low-risk.
Attachment #324951 - Flags: approval1.8.1.15?
Comment on attachment 324951 [details] [diff] [review]
Remove errant files on Linux

Approved for 1.8.1.15 and 1.8.1.16, a=dveditz for release-drivers 

Please land on both the main MOZILLA_1_8_BRANCH and the current release _RELBRANCH
Attachment #324951 - Flags: approval1.8.1.16+
Attachment #324951 - Flags: approval1.8.1.15?
Attachment #324951 - Flags: approval1.8.1.15+
(Assignee)

Comment 11

10 years ago
MOZILLA_1_8_BRANCH:
Checking in removed-files.in;
/cvsroot/mozilla/mail/installer/removed-files.in,v  <--  removed-files.in
new revision: 1.1.2.21; previous revision: 1.1.2.20
done

GECKO181_20080612_RELBRANCH:
Checking in removed-files.in;
/cvsroot/mozilla/mail/installer/removed-files.in,v  <--  removed-files.in
new revision: 1.1.2.20.22.1; previous revision: 1.1.2.20
done

Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: fixed1.8.1.15
Resolution: --- → FIXED
Keywords: fixed1.8.1.16
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.