431888 - Tb 2.0.0.14 Talkback drop has extra, Mac OS files in it

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[J. Paul Reed [:preed]]

I got my automagical update to 2.0.0.14 today, and I started via the commandline on Linux; I saw:

libxpt: bad magic header in input file; found '', expected 'XPCOM\nTypeLi\r\n\032'
libxpt: bad magic header in input file; found '', expected 'XPCOM\nTypeLi\r\n\032'
libxpt: bad magic header in input file; found '', expected 'XPCOM\nTypeLi\r\n\032'

I've been starting Tb from the commandline on this machine (Ubuntu 64-bit) ever since I've had it, and never seen these errors.

I'll try it with 2.0.0.12 today, and see if it has the error.

I haven't seen any functionality that's broken or affected, but... depending on the xpt files that may be bad (?), it could be a lurking surprise.

Comment 1

[J. Paul Reed [:preed]]

Not seeing this on Tb 2.0.0.9 (which I already had downloaded); I'll try 2.0.0.12 in a moment.

Comment 2

[J. Paul Reed [:preed]]

I think I figured out the problem here; it looks like the last time the talkback bundles were packaged, a bunch of Mac OS attribute files were included with the drop:

./[e-mail]
./[e-mail]/._chrome.manifest
./[e-mail]/components/._qfaservices.xpt
./[e-mail]/components/talkback/._master.ini
./[e-mail]/components/talkback/._talkback.so
./[e-mail]/components/talkback/._talkback
./[e-mail]/components/talkback/._XTalkback.ad
./[e-mail]/components/._talkback
./[e-mail]/components/._libqfaservices.so
./[e-mail]/._components

If you run strings on any of these files, you'll see:

Mac OS X        
ATTR
com.apple.quarantine
q/0000;47aa1bca;Minefield.app;|org.mozilla.firefox

The problem here is the XPT linker is finding ./[e-mail]/components/._qfaservices.xpt, but it's not an xpt file, so it's bucket of fail.

Looks like those talkback bundles need to be redone to pull these files out (and these files added to removedfiles for automatic update?)

Comment 3

[J. Paul Reed [:preed]]

Bug 403701 has some info on this.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Thanks for catching this Paul, going to test the fix on staging.

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Turns out Firefox avoids this problem by having a packages-static for both windows and linux which mostly includes specific files, and where it does a * wildcard that doesn't match files beginning with ".". Thunderbird only has a packages-static for windows. :-S

Anyway, I copied 
 /builds/tinderbox/talkback-thunderbird-1.8-linux.tar.bz2
to 
 /builds/tinderbox/old-talkback/
and fixed up the original file. Forcing a nightly to make sure it removes the files properly on an update.

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

From updates/last-update.log when updating from 2008061303 to 2008061305:

EXECUTE REMOVE extensions/[e-mail]
EXECUTE REMOVE extensions/[e-mail]/._chrome.manifest
EXECUTE REMOVE extensions/[e-mail]/._components
EXECUTE REMOVE extensions/[e-mail]/components/._libqfaservices.so
EXECUTE REMOVE extensions/[e-mail]/components/._qfaservices.xpt
EXECUTE REMOVE extensions/[e-mail]/components/._talkback
EXECUTE REMOVE extensions/[e-mail]/components/talkback/._XTalkback.ad
EXECUTE REMOVE extensions/[e-mail]/components/talkback/._master.ini
EXECUTE REMOVE extensions/[e-mail]/components/talkback/._talkback
EXECUTE REMOVE extensions/[e-mail]/components/talkback/._talkback.so

So that's fine for the partial update case.

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

(In reply to comment #5)
> Anyway, I copied 
>  /builds/tinderbox/talkback-thunderbird-1.8-linux.tar.bz2
> to 
>  /builds/tinderbox/old-talkback/
> and fixed up the original file. Forcing a nightly to make sure it removes the
> files properly on an update.

On crazyhorse, that is. 

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Remove errant files on Linux

This'll make sure we remove them for both partial and complete updates.

Comment 9

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 324951 [details] [diff] [review]
Remove errant files on Linux

drivers, requesting approval to land this, ideally on both the 1.8 branch and the relbranch for Tb2.0.0.15. It isn't a serious bug but the fix is self-contained and low-risk.

Comment 10

[Daniel Veditz [:dveditz]]

Comment on attachment 324951 [details] [diff] [review]
Remove errant files on Linux

Approved for 1.8.1.15 and 1.8.1.16, a=dveditz for release-drivers 

Please land on both the main MOZILLA_1_8_BRANCH and the current release _RELBRANCH

Comment 11

[Nick Thomas [:nthomas] (UTC+12)]

MOZILLA_1_8_BRANCH:
Checking in removed-files.in;
/cvsroot/mozilla/mail/installer/removed-files.in,v  <--  removed-files.in
new revision: 1.1.2.21; previous revision: 1.1.2.20
done

GECKO181_20080612_RELBRANCH:
Checking in removed-files.in;
/cvsroot/mozilla/mail/installer/removed-files.in,v  <--  removed-files.in
new revision: 1.1.2.20.22.1; previous revision: 1.1.2.20
done