Closed Bug 431940 Opened 13 years ago Closed 12 years ago

Port |Bug 402207 – SSL error page "Add Exception" support should be pref-controlled| to SeaMonkey

Categories

(SeaMonkey :: Security, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0b2

People

(Reporter: sgautherie, Assigned: sgautherie)

References

Details

Attachments

(1 file, 1 obsolete file)

SeaMonkey misses the preference handling from the two </browser/*> files.

The current behavior seems to be |value = 1|,
but is not configurable.
Depends on: 407369
Attached patch (Av1) </suite/*> (obsolete) — Splinter Review
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008050202 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #319100 - Flags: review?
Attachment #319100 - Flags: review? → review?(iann_bugzilla)
Attachment #319100 - Flags: review?(iann_bugzilla) → review+
Keywords: checkin-needed
Does this need SR? I'm not 100% sure about SeaMonkey review rules.
Comment on attachment 319100 [details] [diff] [review]
(Av1) </suite/*>

Not sure if this needs SR or not. Please advise.
Attachment #319100 - Flags: superreview?(neil)
Neil, ping ?
Removing for now as there seems to be a pending sr requirement.
Keywords: checkin-needed
Severity: enhancement → trivial
Depends on: 431826
Target Milestone: seamonkey2.0a1 → seamonkey2.0b2
Av1, updated to current trunk.


(In reply to comment #3)
> Not sure if this needs SR or not. Please advise.

/suite/ only patches don't (nowadays).
Attachment #319100 - Attachment is obsolete: true
Attachment #392806 - Flags: review?(iann_bugzilla)
Attachment #319100 - Flags: superreview?(neil)
Comment on attachment 392806 [details] [diff] [review]
(Av1a) Port bug 402207 + bug 407369 + bug 431826 (relevant part)
[Checkin: Comment 9]

r=me
Attachment #392806 - Flags: review?(iann_bugzilla) → review+
(In reply to comment #4)
> Neil, ping ?
Sorry, I get so many requests that from time to time some sink without trace :-(

Regarding the patch, I wonder why Firefox bothered with the try/catch...
Comment on attachment 392806 [details] [diff] [review]
(Av1a) Port bug 402207 + bug 407369 + bug 431826 (relevant part)
[Checkin: Comment 9]


http://hg.mozilla.org/comm-central/rev/4344cc9a28a7


(In reply to comment #8)
> Regarding the patch, I wonder why Firefox bothered with the try/catch...

Bug 402207 doesn't say.
I assume they prefer to fall back to the default behavior rather than throwing, in case anything/whatever goes wrong with the pref retrieval.
Yet, feel free to file a bug to get try+catch removed from FF (and SM), if need be.
Attachment #392806 - Attachment description: (Av1a) Port bug 402207 + bug 407369 + bug 431826 (relevant part) → (Av1a) Port bug 402207 + bug 407369 + bug 431826 (relevant part) [Checkin: Comment 9]
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.