Closed Bug 431962 Opened 16 years ago Closed 16 years ago

dehydra_intCstToString doesn't work properly on a mac

Categories

(Developer Infrastructure :: Source Code Analysis, defect)

x86
macOS
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: vladimir.sukhoy, Unassigned)

References

Details

Attachments

(1 file)

Attached patch fixSplinter Review
The tests for 64-bit int literals fail on mac. This is because TREE_INT_CST_LOW(int_cst) is actually 64-bit wide there and contains all of the bits we need in that function.

This is quite illustrative: that patch was done (mostly by me) while being on Linux. The unit tests allowed to identify the problem at once.
Attachment #319103 - Flags: review?(dmandelin)
Attachment #319103 - Flags: review?(dmandelin) → review+
pushed.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: