431978 - Don't pass strings to setTimeout

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Phil Ringnalda (:philor)]

As pretty much every guide to either efficient or secure JavaScript says, setTimeout("foopy()", 0) is almost never what you want to do.

Comment 1

[Phil Ringnalda (:philor)]

Attachment: Fix v.1

Pretty straightforward, with just a little collateral cleanup in addressingWidgetOverlay.js, where the recursive setTimeout bits have been commented out since March 2002, well before we even got around to forking it, so I think it's quite safe to get rid of them. (I was hoping to get rid of the whole use of a setTimeout, but I was still able to reproduce bug 21280, in Windows only, by pegging the CPU with builds going in two other VMs at the same time.)

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 319244 [details] [diff] [review]
Fix v.1

Looks good, r=mkmelin

In addressingWidgetOverlay.js you could take the opportunity to add a space between the // comments and move the else if to one row.

Comment 3

[Phil Ringnalda (:philor)]

Good idea, thanks. De-nitted and landed.

mail/base/content/searchBar.js 1.47
mail/components/migration/content/migration.js 1.11
mail/components/compose/content/addressingWidgetOverlay.js 1.15
mail/components/compose/content/MsgComposeCommands.js 1.134
mail/components/preferences/downloadactions.js 1.7
mail/components/addrbook/content/abCommon.js 1.30

Comment 4

[Philip Chee]

philor:
One string left in mailnews/
http://mxr.mozilla.org/comm-central/source/mailnews/addrbook/content/abMailListDialog.js#504

I'll fix it in SeaMonkey Bug 571517 unless you beat me to it.