Closed
Bug 431995
Opened 16 years ago
Closed 16 years ago
mingw bustage - making libs in security/manager fails to find libmime3.dll.a
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 441976
People
(Reporter: Mook, Unassigned)
References
()
Details
Attachments
(1 file)
1.14 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
This is fallout from bug 429133. When building for Windows, the only case where LIB_SUFFIX != IMPORT_LIB_SUFFIX is when build GCC (when building with MSVC, they are both "lib"). Mossop says he probably copied the logic from [1] - except that also does a GNU_CC check. This patch just removes the check and always uses LIB_SUFFIX because it doesn't really make sense to use two separate variables of the same value [2]. [1] http://mxr-test.landfill.bugzilla.org/mozilla/source/configure.in#4037 [2] http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/configure.in&rev=1.1991&mark=1942,1945#1927
Attachment #319150 -
Flags: review?(ted.mielczarek)
Updated•16 years ago
|
Attachment #319150 -
Flags: review?(ted.mielczarek) → review+
Those variables have intentionally different purposes even if they do currently have the same value. They shouldn't be treated as interchangeable.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → DUPLICATE
Comment 2•16 years ago
|
||
Mook, are you building on Windows, or Linux (cross compiling for the target Windows/MinGW)?
wtc: I'm cross-compiling from a Linux-i686 host using the mingw32 toolchain. (Thanks for weighing in, cls)
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•