Closed Bug 432018 Opened 16 years ago Closed 15 years ago

Initial task list column order and entries in column dropdown menu are messed up

Categories

(Calendar :: Tasks, defect)

x86
Windows XP
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: ssitter, Assigned: prasad)

References

Details

(Keywords: regression)

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.15pre) Gecko/2008050221 Calendar/0.9pre

Lightning 0.9pre (2008050219) + Thunderbird 2.0.0.15pre (20080503)

Initial column order and entries in column dropdown menu after starting with a new profile are messed up.

    Task List            Task Mode
    [x] Done             [x] Done
    [ ] Completed        [ ] Completed
    [x] Priority         [x] Priority
    [ ] % Complete       [ ] % Complete
    [ ] Start            [x] Start
    [ ] Category         [ ] Category
    [ ] Location         [ ] Location
    [ ] Due              [x] Due
    [ ] Status           [ ] Status
    [x] Title            [x] Title
    [ ] Calendar Name    [ ] Calendar Name

After executing "Restore Natural Order" / "Restore Defaults" from column dropdown menu the column order and the entries in column dropdown menu are correct:

    Task List            Task Mode
    [x] Done             [x] Done
    [x] Priority         [x] Priority
    [x] Title            [x] Title
    [ ] Start            [x] Start
    [ ] Due              [x] Due
    [ ] Completed        [ ] Completed
    [ ] % Complete       [ ] % Complete
    [ ] Category         [ ] Category
    [ ] Location         [ ] Location
    [ ] Status           [ ] Status
    [ ] Calendar Name    [ ] Calendar Name

This is the same order I'd expect when starting with a new profile. 
Used to work with Lightning 0.8.
Regression range:
    Works in Sunbird 0.9pre (2008041020)
    Fails in Sunbird 0.9pre (2008041121)

Checkins during regression range: http://tinyurl.com/58djle -> Bug 410755.

It works again on trunk and 1.8 branch as soon as I remove the ordinal="2", ordinal="4", ... changes that were added to the splitter elements with Bug 410755.

Prasad, what was the purpose for the change? Is it's required? It seems that both trunk and 1.8 branch work better without that change.
Blocks: 410755
Keywords: regression
Version: Mozilla 1.8 Branch → unspecified
With out the ordinal="2", ... The separators are not getting the right ordinals on the trunk because of which, the columns cannot be resized.

I will check if there are other alternatives to solve the problem.  Sorry I did not test it on a new profile before submitting the patch.
Status: NEW → ASSIGNED
When writing a patch yesterday I noticed this issue too. When removing the ordinals the columns cannot be resized initially. But after executing "Restore Defaults" from column dropdown menu the columns can be resized.

There is probably some other thing missing. No other tree in mxr.mozilla.org hard codes the ordinal for the splitter as far as I see.
Assignee: nobody → prasad
Status: ASSIGNED → NEW
Prasad, any progress on this issue?
Stefan, I don't think there is anything wrong is explicitly specifying the ordinals.  Ordinal is a generic attribute used to specify the position of an element in its parent.

The current problem can be fixed by adding the default values for ordinals when using the "calendar-task-tree".  Eg: In calendar-task-view.xul, you can add an attribute that says ordinals="1,3,5,7,9,11,...21" to calendar-task-tree

Now after we add this, since the constructor read the ordinals attribute and sets these attributes to all the columns, the tree column/splitters will end up having the ordinals in a proper order to begin with.  We anyway persist the ordinals to be used later on.
Resolving as WORKSFORME because I can't reproduce the issue anymore using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090121 Calendar/1.0pre (BuildID: 20090121125420).
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.