432052 - Accessibility fixes for mailnews/base/prefs and mailnews/compose/prefs XUL files.

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Marco Zehe (:MarcoZ)]

Add missing label associations, aria-labelledby where it makes sense (like when an expression is made up out of multiple controls), and possibly others.

Comment 1

[Marco Zehe (:MarcoZ)]

Attachment: Patch

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 319207 [details] [diff] [review]
Patch

pref-junk.xul
>     <radiogroup id="manualMarkMode"
>                 class="indent"
>-                prefstring="mail.spam.manualMarkMode">
>+                prefstring="mail.spam.manualMarkMode"
>+                aria-labelledby="manualMark">

If you put aria-labelledby on the previous line to prefstring, you'll make this all just one addition.

pref-notifications.xul
>     <hbox align="center" class="indent" id="newMailNotificationSoundSelectBox">
>-      <radiogroup id="newMailNotificationType" prefstring="mail.biff.play_sound.type" orient="vertical">
>+      <radiogroup id="newMailNotificationType" prefstring="mail.biff.play_sound.type" orient="vertical" aria-labelledby="newMailNotification">

Please put orient and aria-labelledby on a new line. This one is already too long.

>     <hbox align="center" class="indent">
>       <textbox readonly="true" flex="1" id="mailnewsSoundFileUrl" preftype="string"
>-           prefstring="mail.biff.play_sound.url"/>
>+           prefstring="mail.biff.play_sound.url" aria-labelledby="custom"/>

Please align the start of prefstring with the start of readonly.

pref-offline.xul
>     <textbox id="offlineCompactFolderMin" size="5" value="100"
>-      preftype="int" prefstring="mail.purge_threshhold"/>
>-    <label value="&kb.label;"/>
>+      preftype="int" prefstring="mail.purge_threshhold" aria-labelledby="offlineCompactFolder offlineCompactFolderMin kbLabel"/>
>+    <label value="&kb.label;" id="kbLabel"/>

I don't understand why the aria-labelledby in references the offlineCompactFolderMin id which is its own id. Same comment with autoSaveInterval and wrapLength in pref-composing_messages.xul.

Comment 3

[[e-mail]]

(In reply to comment #2)
> I don't understand why the aria-labelledby in references the
> offlineCompactFolderMin id which is its own id. Same comment with
> autoSaveInterval and wrapLength in pref-composing_messages.xul.
I know this one! It's so the screen reader says
"Automatically save the message every 5 minutes"
(in the case of autoSaveInterval) as a single string.

Comment 4

[Marco Zehe (:MarcoZ)]

I've adjusted all review comments except for the one in pref-offline.xul. This one has been updated and already contains all my proposed fixes.

Comment 5

[Marco Zehe (:MarcoZ)]

Attachment: Updated patch

Reduce edits, replace xul:description/aria-labelledby constructs with xul:label plus control attribute.

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 320684 [details] [diff] [review]
Updated patch

Index: mailnews/base/prefs/resources/content/pref-notifications.xul

       <textbox readonly="true" flex="1" id="mailnewsSoundFileUrl" preftype="string"
-           prefstring="mail.biff.play_sound.url"/>
+                aria-labelledby="custom"
+                prefstring="mail.biff.play_sound.url"/>

nit: aria-labelledby and prefstring are one space too far to the right.

r=me with that fixed.

Comment 7

[Marco Zehe (:MarcoZ)]

Nit fixed, thanks!

Comment 8

[[e-mail]]

Comment on attachment 320684 [details] [diff] [review]
Updated patch

Again, I don't mind about that label/description issue.

Comment 9

[Marco Zehe (:MarcoZ)]

Checking in mailnews/base/prefs/resources/content/pref-junk.xul;
/cvsroot/mozilla/mailnews/base/prefs/resources/content/pref-junk.xul,v  <--  pref-junk.xul
new revision: 1.4; previous revision: 1.3
done
Checking in mailnews/base/prefs/resources/content/pref-notifications.xul;
/cvsroot/mozilla/mailnews/base/prefs/resources/content/pref-notifications.xul,v  <--  pref-notifications.xul
new revision: 1.14; previous revision: 1.13
done
Checking in mailnews/base/prefs/resources/content/pref-tags.xul;
/cvsroot/mozilla/mailnews/base/prefs/resources/content/pref-tags.xul,v  <--  pref-tags.xul
new revision: 1.3; previous revision: 1.2
done
Checking in mailnews/compose/prefs/resources/content/pref-composing_messages.xul;
/cvsroot/mozilla/mailnews/compose/prefs/resources/content/pref-composing_messages.xul,v  <--  pref-composing_messages.xul
new revision: 1.53; previous revision: 1.52
done