Closed
Bug 432052
Opened 16 years ago
Closed 16 years ago
Accessibility fixes for mailnews/base/prefs and mailnews/compose/prefs XUL files.
Categories
(Thunderbird :: Preferences, defect)
Thunderbird
Preferences
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3
People
(Reporter: MarcoZ, Assigned: MarcoZ)
References
Details
(Keywords: access)
Attachments
(1 file, 1 obsolete file)
5.59 KB,
patch
|
standard8
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
Add missing label associations, aria-labelledby where it makes sense (like when an expression is made up out of multiple controls), and possibly others.
Assignee | ||
Comment 1•16 years ago
|
||
Attachment #319207 -
Flags: superreview?(neil)
Attachment #319207 -
Flags: review?(bugzilla)
Comment 2•16 years ago
|
||
Comment on attachment 319207 [details] [diff] [review] Patch pref-junk.xul > <radiogroup id="manualMarkMode" > class="indent" >- prefstring="mail.spam.manualMarkMode"> >+ prefstring="mail.spam.manualMarkMode" >+ aria-labelledby="manualMark"> If you put aria-labelledby on the previous line to prefstring, you'll make this all just one addition. pref-notifications.xul > <hbox align="center" class="indent" id="newMailNotificationSoundSelectBox"> >- <radiogroup id="newMailNotificationType" prefstring="mail.biff.play_sound.type" orient="vertical"> >+ <radiogroup id="newMailNotificationType" prefstring="mail.biff.play_sound.type" orient="vertical" aria-labelledby="newMailNotification"> Please put orient and aria-labelledby on a new line. This one is already too long. > <hbox align="center" class="indent"> > <textbox readonly="true" flex="1" id="mailnewsSoundFileUrl" preftype="string" >- prefstring="mail.biff.play_sound.url"/> >+ prefstring="mail.biff.play_sound.url" aria-labelledby="custom"/> Please align the start of prefstring with the start of readonly. pref-offline.xul > <textbox id="offlineCompactFolderMin" size="5" value="100" >- preftype="int" prefstring="mail.purge_threshhold"/> >- <label value="&kb.label;"/> >+ preftype="int" prefstring="mail.purge_threshhold" aria-labelledby="offlineCompactFolder offlineCompactFolderMin kbLabel"/> >+ <label value="&kb.label;" id="kbLabel"/> I don't understand why the aria-labelledby in references the offlineCompactFolderMin id which is its own id. Same comment with autoSaveInterval and wrapLength in pref-composing_messages.xul.
Comment 3•16 years ago
|
||
(In reply to comment #2) > I don't understand why the aria-labelledby in references the > offlineCompactFolderMin id which is its own id. Same comment with > autoSaveInterval and wrapLength in pref-composing_messages.xul. I know this one! It's so the screen reader says "Automatically save the message every 5 minutes" (in the case of autoSaveInterval) as a single string.
Assignee | ||
Comment 4•16 years ago
|
||
I've adjusted all review comments except for the one in pref-offline.xul. This one has been updated and already contains all my proposed fixes.
Assignee | ||
Comment 5•16 years ago
|
||
Reduce edits, replace xul:description/aria-labelledby constructs with xul:label plus control attribute.
Attachment #319207 -
Attachment is obsolete: true
Attachment #320684 -
Flags: superreview?(neil)
Attachment #320684 -
Flags: review?(bugzilla)
Attachment #319207 -
Flags: superreview?(neil)
Attachment #319207 -
Flags: review?(bugzilla)
Comment 6•16 years ago
|
||
Comment on attachment 320684 [details] [diff] [review] Updated patch Index: mailnews/base/prefs/resources/content/pref-notifications.xul <textbox readonly="true" flex="1" id="mailnewsSoundFileUrl" preftype="string" - prefstring="mail.biff.play_sound.url"/> + aria-labelledby="custom" + prefstring="mail.biff.play_sound.url"/> nit: aria-labelledby and prefstring are one space too far to the right. r=me with that fixed.
Attachment #320684 -
Flags: review?(bugzilla) → review+
Assignee | ||
Comment 7•16 years ago
|
||
Nit fixed, thanks!
Comment 8•16 years ago
|
||
Comment on attachment 320684 [details] [diff] [review] Updated patch Again, I don't mind about that label/description issue.
Attachment #320684 -
Flags: superreview?(neil) → superreview+
Assignee | ||
Comment 9•16 years ago
|
||
Checking in mailnews/base/prefs/resources/content/pref-junk.xul; /cvsroot/mozilla/mailnews/base/prefs/resources/content/pref-junk.xul,v <-- pref-junk.xul new revision: 1.4; previous revision: 1.3 done Checking in mailnews/base/prefs/resources/content/pref-notifications.xul; /cvsroot/mozilla/mailnews/base/prefs/resources/content/pref-notifications.xul,v <-- pref-notifications.xul new revision: 1.14; previous revision: 1.13 done Checking in mailnews/base/prefs/resources/content/pref-tags.xul; /cvsroot/mozilla/mailnews/base/prefs/resources/content/pref-tags.xul,v <-- pref-tags.xul new revision: 1.3; previous revision: 1.2 done Checking in mailnews/compose/prefs/resources/content/pref-composing_messages.xul; /cvsroot/mozilla/mailnews/compose/prefs/resources/content/pref-composing_messages.xul,v <-- pref-composing_messages.xul new revision: 1.53; previous revision: 1.52 done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•