The Solaris trees are broken: http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Ports/1209840840.1209840945.25428.gz.
Created attachment 319223 [details] [diff] [review] patch v1
Attachment #319223 - Flags: review?(tony)
Assignee: nobody → alfred.peng
Component: General → Phishing Protection
QA Contact: general → phishing.protection
Status: NEW → ASSIGNED
Target Milestone: --- → Firefox 3
We shouldn't break Solaris - fix seems simple enough. Tony, if you have a moment this weekend, can you please review?
Flags: blocking-firefox3? → blocking-firefox3+
Whiteboard: [has patch][needs review tony]
Comment on attachment 319223 [details] [diff] [review] patch v1 Looks fine, but I don't know enough about the solaris build to understand why it broke or why this fixes it.
Attachment #319223 - Flags: review?(tony) → review+
Attachment #319223 - Flags: approval1.9? → approval1.9+
Whiteboard: [has patch][needs review tony] → [has patch][has review][has approval]
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Whiteboard: [has patch][has review][has approval]
Component: Phishing Protection → Phishing Protection
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.