Closed
Bug 432066
Opened 14 years ago
Closed 14 years ago
Solaris build is broken after the checkin of bug 431754
Categories
(Toolkit :: Safe Browsing, defect)
Tracking
()
RESOLVED
FIXED
Firefox 3
People
(Reporter: alfred.peng, Assigned: alfred.peng)
References
Details
(Keywords: regression)
Attachments
(1 file)
1.89 KB,
patch
|
tony
:
review+
mconnor
:
approval1.9+
|
Details | Diff | Splinter Review |
The Solaris trees are broken: http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Ports/1209840840.1209840945.25428.gz.
Assignee | ||
Comment 1•14 years ago
|
||
Attachment #319223 -
Flags: review?(tony)
Updated•14 years ago
|
Assignee: nobody → alfred.peng
Component: General → Phishing Protection
QA Contact: general → phishing.protection
Updated•14 years ago
|
Status: NEW → ASSIGNED
Flags: blocking-firefox3?
Target Milestone: --- → Firefox 3
Updated•14 years ago
|
Keywords: regression
Comment 2•14 years ago
|
||
We shouldn't break Solaris - fix seems simple enough. Tony, if you have a moment this weekend, can you please review?
Flags: blocking-firefox3? → blocking-firefox3+
Whiteboard: [has patch][needs review tony]
Comment 3•14 years ago
|
||
Comment on attachment 319223 [details] [diff] [review] patch v1 Looks fine, but I don't know enough about the solaris build to understand why it broke or why this fixes it.
Attachment #319223 -
Flags: review?(tony) → review+
Updated•14 years ago
|
Attachment #319223 -
Flags: approval1.9?
Updated•14 years ago
|
Attachment #319223 -
Flags: approval1.9? → approval1.9+
Updated•14 years ago
|
Whiteboard: [has patch][needs review tony] → [has patch][has review][has approval]
Updated•14 years ago
|
Keywords: checkin-needed
Comment 4•14 years ago
|
||
mozilla/toolkit/components/url-classifier/src/nsUrlClassifierStreamUpdater.cpp 1.23
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [has patch][has review][has approval]
Updated•8 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•