If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Solaris build is broken after the checkin of bug 431754

RESOLVED FIXED in Firefox 3

Status

()

Product:
Toolkit
Component:
Safe Browsing
RESOLVED FIXED
Reported:
10 years ago
Modified:
3 years ago

People

(Reporter: Alfred Peng, Assigned: Alfred Peng)

Tracking

({regression})

Version:
Trunk
Target:
Firefox 3
x86
SunOS
Keywords:
regression
Points:
---
Bug Flags:
blocking-firefox3 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

patch v1
1.89 KB, patch
Tony Chang (Google)
: review+
mconnor
: approval1.9+
Details | Diff | Splinter Review
(Assignee)

Description

•
10 years ago 
The Solaris trees are broken: http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Ports/1209840840.1209840945.25428.gz.
(Assignee)

Comment 1

•
10 years ago 
Created attachment 319223 [details] [diff] [review]
patch v1
Attachment #319223 - Flags: review?(tony)
Assignee: nobody → alfred.peng
Component: General → Phishing Protection
QA Contact: general → phishing.protection
Status: NEW → ASSIGNED
Flags: blocking-firefox3?
Target Milestone: --- → Firefox 3
Blocks: 431754
Keywords: regression

Comment 2

•
10 years ago 
We shouldn't break Solaris - fix seems simple enough. Tony, if you have a moment this weekend, can you please review?
Flags: blocking-firefox3? → blocking-firefox3+
Whiteboard: [has patch][needs review tony]

Comment 3

•
10 years ago 
Comment on attachment 319223 [details] [diff] [review]
patch v1

Looks fine, but I don't know enough about the solaris build to understand why it broke or why this fixes it.
Attachment #319223 - Flags: review?(tony) → review+
Attachment #319223 - Flags: approval1.9?

Updated

•
10 years ago
Attachment #319223 - Flags: approval1.9? → approval1.9+
Whiteboard: [has patch][needs review tony] → [has patch][has review][has approval]

Updated

•
10 years ago
Keywords: checkin-needed

Comment 4

•
10 years ago 
mozilla/toolkit/components/url-classifier/src/nsUrlClassifierStreamUpdater.cpp 	1.23
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [has patch][has review][has approval]
Component: Phishing Protection → Phishing Protection
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.