Closed
Bug 432109
Opened 16 years ago
Closed 16 years ago
nsSuiteGlue never removes observers
Categories
(SeaMonkey :: General, defect)
SeaMonkey
General
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.0a1
People
(Reporter: kairo, Assigned: kairo)
Details
Attachments
(1 file)
|
1.94 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
When helping someone else with nsSuiteGlue observers, I realized that the _dispose() function is never actually called and observers are never removed. I obviously deleted too much when porting this from Firefox.
|
Assignee | |
Comment 1•16 years ago
|
||
This patch adds the missing piece, listens to xpcom-shutdown and calls _dispose() at that point.
Attachment #319268 -
Flags: review?(neil)
|
||
Comment 2•16 years ago
|
||
Comment on attachment 319268 [details] [diff] [review] patch: call _dispose() on shutdown r=me by code inspection (comparsion with nsBrowserGlue.js)
Attachment #319268 -
Flags: review?(neil) → review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
thanks, checked in.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•