Closed
Bug 432112
Opened 16 years ago
Closed 16 years ago
Cmd+? does not give Help (? in the shifted position)
Categories
(Firefox :: Keyboard Navigation, defect)
Tracking
()
RESOLVED
FIXED
Firefox 3
People
(Reporter: MatsPalmgren_bugz, Assigned: masayuki)
References
Details
(Keywords: regression, Whiteboard: [key hell])
Attachments
(1 file)
1.47 KB,
patch
|
Gavin
:
review+
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
STEPS TO REPRODUCE Press Cmd Shift + on a Mac with Swedish keyboard layout. (the key has + in the unshifted position and ? is in the shifted position) ACTUAL RESULT The "Help" menu item flashes but nothing else happens. EXPECTED RESULT The "Help" menu item flashes and a new tab/window opens with Help contents. PLATFORMS AND BUILDS TESTED Bug occurs in Firefox 2008-05-02-09 on MacOSX 10.5.2 Regression window: 2008-04-07-04 -- 2008-04-08-04 http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2008-04-07+03%3A00&maxdate=2008-04-08+05%3A00&cvsroot=%2Fcvsroot
Assignee | ||
Comment 1•16 years ago
|
||
In the current our strategy of key handling, this is "correct" behavior...
Assignee | ||
Comment 2•16 years ago
|
||
(In reply to comment #1) > In the current our strategy of key handling, this is "correct" behavior... Er, maybe, I misunderstand. You pressed Cmd+Shift+'+' but Cmd+'?' is not executed, right?? If so, that will be fixed by bug 429510.
Depends on: 429510
Comment 3•16 years ago
|
||
(In reply to comment #2) > You pressed Cmd+Shift+'+' but Cmd+'?' is not executed, right?? If so, that will > be fixed by bug 429510. Bug 429510 is not enough because shortcut for Firefox Help is actually Cmd+Shift+'/', and Cmd+'?' does nothing. http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/browser/base/content/baseMenuOverlay.xul&rev=1.20&mark=116-124#115 http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/browser/locales/en-US/chrome/browser/baseMenuOverlay.dtd&rev=1.10&mark=24-27#21 This workaround should be removed if shifted shortcut can be handled correctly.
Assignee | ||
Comment 4•16 years ago
|
||
(In reply to comment #3) > (In reply to comment #2) > > You pressed Cmd+Shift+'+' but Cmd+'?' is not executed, right?? If so, that will > > be fixed by bug 429510. > > Bug 429510 is not enough because shortcut for Firefox Help is actually > Cmd+Shift+'/', and Cmd+'?' does nothing. > > http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/browser/base/content/baseMenuOverlay.xul&rev=1.20&mark=116-124#115 > http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/browser/locales/en-US/chrome/browser/baseMenuOverlay.dtd&rev=1.10&mark=24-27#21 > > This workaround should be removed if shifted shortcut can be handled correctly. Oh, right. Thank you!
Assignee | ||
Updated•16 years ago
|
Flags: blocking1.9?
Assignee | ||
Updated•16 years ago
|
Whiteboard: [key hell]
Assignee | ||
Updated•16 years ago
|
Component: Keyboard: Navigation → Keyboard Navigation
Flags: blocking1.9?
Product: Core → Firefox
QA Contact: keyboard.navigation → keyboard.navigation
Target Milestone: --- → Firefox 3
Assignee | ||
Updated•16 years ago
|
Flags: blocking-firefox3?
Assignee | ||
Comment 5•16 years ago
|
||
Updated•16 years ago
|
Flags: blocking-firefox3? → blocking-firefox3+
Whiteboard: [key hell] → [key hell][has patch][needs review gavin]
Comment 6•16 years ago
|
||
Comment on attachment 319336 [details] [diff] [review] Patch v1.0 >Index: browser/base/content/baseMenuOverlay.xul >-<!-- On mac, we map Cmd+Shift+/, but show Cmd+? >- (that's for en-US, it might be different for other keyboard layouts) --> >- <key id="key_openHelpMac" >- oncommand="openHelpLink('firefox-help');" >- key="&openHelpMac.commandkey;" >- modifiers="&openHelpMac.modifiers;"/> > <key id="key_openHelpMacFrontend" >+ oncommand="openHelpLink('firefox-help');" > key="&openHelpMac.frontendCommandkey;" > modifiers="&openHelpMac.frontendModifiers;"/> Please file a followup on renaming frontendCommandkey/frontendModifiers to commandKey/modifiers and removing the old strings once we can change strings again.
Attachment #319336 -
Flags: review?(gavin.sharp) → review+
Updated•16 years ago
|
Whiteboard: [key hell][has patch][needs review gavin] → [key hell][has patch]
Updated•16 years ago
|
Attachment #319336 -
Flags: approval1.9?
Comment 7•16 years ago
|
||
Comment on attachment 319336 [details] [diff] [review] Patch v1.0 a1.9=beltzner
Attachment #319336 -
Flags: approval1.9? → approval1.9+
Updated•16 years ago
|
Whiteboard: [key hell][has patch] → [key hell][has review][has approval]
Updated•16 years ago
|
Keywords: checkin-needed
Updated•16 years ago
|
Whiteboard: [key hell][has review][has approval] → [key hell][has patch][has review][has approval]
Updated•16 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 8•16 years ago
|
||
-> checked-in. For non-Latin keyboard layout, we need to fix bug 429510.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [key hell][has patch][has review][has approval] → [key hell]
Assignee | ||
Comment 9•16 years ago
|
||
tb issue of this bug is filed to bug 432382.
Comment 10•16 years ago
|
||
Is everyone here aware of the fact that the key combo is localized as well? I mean, in the sv-SE version of Firefox we have: <!ENTITY openHelpMac.commandkey "+"> <!ENTITY openHelpMac.modifiers "accel,shift"> <!ENTITY openHelpMac.frontendCommandkey "?"> <!ENTITY openHelpMac.frontendModifiers "accel"> Is there a bug filed on all the locales that will need to change?
Comment 11•16 years ago
|
||
This is just obsoleting strings, isn't it?
Assignee | ||
Comment 12•16 years ago
|
||
(In reply to comment #11) > This is just obsoleting strings, isn't it? Exactly. at localized build, the any keyboard layout should be able to access to help with Cmd+'?'. Now, it's resolved by core level. So, localizers don't need to think the problem.
Assignee | ||
Comment 13•16 years ago
|
||
see also bug 432380.
Comment 14•16 years ago
|
||
Right, sorry - now I looked at attachment #319336 [details] [diff] [review]. However, in order to open Help on my sv-SE build I have to press Cmd+Shift+-, which doesn't seem to be right...
Comment 15•16 years ago
|
||
And the build is Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; sv-SE; rv:1.9pre) Gecko/2008050604 Minefield/3.0pre
Assignee | ||
Comment 16•16 years ago
|
||
(In reply to comment #14) > However, in order to open Help on my sv-SE build I have to press Cmd+Shift+-, > which doesn't seem to be right... What?? Cmd+Shift++ doesn't open the help?? Cmd+Shift+- should not open help on Swedish layout.
Comment 17•16 years ago
|
||
Pressing Cmd+Shift++ makes the Help menu flash, but nothing happens. Pressing Cmd+Shift+- opens the help placeholder page in a new tab
Assignee | ||
Comment 18•16 years ago
|
||
(In reply to comment #17) > Pressing Cmd+Shift++ makes the Help menu flash, but nothing happens. Pressing > Cmd+Shift+- opens the help placeholder page in a new tab mmmm. It seems that it's same bug as bug 306585 comment 15 and bug 306585 comment 36. Please file a new bug, it may be only 10.5 issue.
Comment 19•16 years ago
|
||
(In reply to comment #18) > mmmm. It seems that it's same bug as bug 306585 comment 15 and bug 306585 > comment 36. Yes, I can reproduce on 10.5. When pressing Cmd+Shift+- on Swedish layout, unshiftedChar is '/' and shiftedChar is '?'.
Assignee | ||
Comment 20•16 years ago
|
||
Sakai-san, thank you. Can the bug be fixed by the patch of bug 432388? That tries to get KCHR resouce with GetResource first.
Comment 21•16 years ago
|
||
> Please file a new bug, it may be only 10.5 issue. Filed bug 432632.
Assignee | ||
Comment 22•16 years ago
|
||
(In reply to comment #21) > > Please file a new bug, it may be only 10.5 issue. > > Filed bug 432632. thanks!
Comment 23•16 years ago
|
||
(In reply to comment #20) > Can the bug be fixed by the patch of bug 432388? That tries to get KCHR resouce > with GetResource first. Not fixed. ::GetResource('kchr', kt.mLayoutID) returns 0.
Assignee | ||
Comment 24•16 years ago
|
||
(In reply to comment #23) > (In reply to comment #20) > > Can the bug be fixed by the patch of bug 432388? That tries to get KCHR resouce > > with GetResource first. > > Not fixed. > > ::GetResource('kchr', kt.mLayoutID) returns 0. Thank you...
You need to log in
before you can comment on or make changes to this bug.
Description
•