Closed Bug 432112 Opened 13 years ago Closed 13 years ago

Cmd+? does not give Help (? in the shifted position)

Categories

(Firefox :: Keyboard Navigation, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3

People

(Reporter: mats, Assigned: masayuki)

References

Details

(Keywords: regression, Whiteboard: [key hell])

Attachments

(1 file)

STEPS TO REPRODUCE
Press Cmd Shift + on a Mac with Swedish keyboard layout.
(the key has + in the unshifted position and ? is in the shifted position)

ACTUAL RESULT
The "Help" menu item flashes but nothing else happens.

EXPECTED RESULT
The "Help" menu item flashes and a new tab/window opens with Help contents.

PLATFORMS AND BUILDS TESTED
Bug occurs in Firefox 2008-05-02-09 on MacOSX 10.5.2

Regression window: 2008-04-07-04 -- 2008-04-08-04
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2008-04-07+03%3A00&maxdate=2008-04-08+05%3A00&cvsroot=%2Fcvsroot
In the current our strategy of key handling, this is "correct" behavior...
(In reply to comment #1)
> In the current our strategy of key handling, this is "correct" behavior...

Er, maybe, I misunderstand.

You pressed Cmd+Shift+'+' but Cmd+'?' is not executed, right?? If so, that will be fixed by bug 429510.
Depends on: 429510
(In reply to comment #2)
> You pressed Cmd+Shift+'+' but Cmd+'?' is not executed, right?? If so, that will
> be fixed by bug 429510.

Bug 429510 is not enough because shortcut for Firefox Help is actually Cmd+Shift+'/', and Cmd+'?' does nothing.

http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/browser/base/content/baseMenuOverlay.xul&rev=1.20&mark=116-124#115
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/browser/locales/en-US/chrome/browser/baseMenuOverlay.dtd&rev=1.10&mark=24-27#21

This workaround should be removed if shifted shortcut can be handled correctly.
(In reply to comment #3)
> (In reply to comment #2)
> > You pressed Cmd+Shift+'+' but Cmd+'?' is not executed, right?? If so, that will
> > be fixed by bug 429510.
> 
> Bug 429510 is not enough because shortcut for Firefox Help is actually
> Cmd+Shift+'/', and Cmd+'?' does nothing.
> 
> http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/browser/base/content/baseMenuOverlay.xul&rev=1.20&mark=116-124#115
> http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/browser/locales/en-US/chrome/browser/baseMenuOverlay.dtd&rev=1.10&mark=24-27#21
> 
> This workaround should be removed if shifted shortcut can be handled correctly.

Oh, right. Thank you!
Component: Keyboard: Navigation → Keyboard Navigation
Flags: blocking1.9?
Product: Core → Firefox
QA Contact: keyboard.navigation → keyboard.navigation
Target Milestone: --- → Firefox 3
Attached patch Patch v1.0Splinter Review
Assignee: nobody → masayuki
Status: NEW → ASSIGNED
Attachment #319336 - Flags: review?(gavin.sharp)
Flags: blocking-firefox3? → blocking-firefox3+
Whiteboard: [key hell] → [key hell][has patch][needs review gavin]
Comment on attachment 319336 [details] [diff] [review]
Patch v1.0

>Index: browser/base/content/baseMenuOverlay.xul

>-<!-- On mac, we map Cmd+Shift+/, but show Cmd+?
>-     (that's for en-US, it might be different for other keyboard layouts) -->
>-        <key id="key_openHelpMac"
>-             oncommand="openHelpLink('firefox-help');"
>-             key="&openHelpMac.commandkey;"
>-             modifiers="&openHelpMac.modifiers;"/>
>         <key id="key_openHelpMacFrontend"
>+             oncommand="openHelpLink('firefox-help');"
>              key="&openHelpMac.frontendCommandkey;"
>              modifiers="&openHelpMac.frontendModifiers;"/>

Please file a followup on renaming frontendCommandkey/frontendModifiers to commandKey/modifiers and removing the old strings once we can change strings again.
Attachment #319336 - Flags: review?(gavin.sharp) → review+
Whiteboard: [key hell][has patch][needs review gavin] → [key hell][has patch]
Comment on attachment 319336 [details] [diff] [review]
Patch v1.0

a1.9=beltzner
Attachment #319336 - Flags: approval1.9? → approval1.9+
Whiteboard: [key hell][has patch] → [key hell][has review][has approval]
Whiteboard: [key hell][has review][has approval] → [key hell][has patch][has review][has approval]
-> checked-in.

For non-Latin keyboard layout, we need to fix bug 429510.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [key hell][has patch][has review][has approval] → [key hell]
Is everyone here aware of the fact that the key combo is localized as well? I mean, in the sv-SE version of Firefox we have:

<!ENTITY openHelpMac.commandkey           "+">
<!ENTITY openHelpMac.modifiers            "accel,shift">
<!ENTITY openHelpMac.frontendCommandkey   "?">
<!ENTITY openHelpMac.frontendModifiers    "accel">

Is there a bug filed on all the locales that will need to change?
This is just obsoleting strings, isn't it?
(In reply to comment #11)
> This is just obsoleting strings, isn't it?

Exactly. at localized build, the any keyboard layout should be able to access to help with Cmd+'?'. Now, it's resolved by core level. So, localizers don't need to think the problem.
Right, sorry - now I looked at attachment #319336 [details] [diff] [review]. However, in order to open
Help on my sv-SE build I have to press Cmd+Shift+-, which doesn't seem to be
right...
And the build is Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; sv-SE; rv:1.9pre) Gecko/2008050604 Minefield/3.0pre
(In reply to comment #14)
> However, in order to open Help on my sv-SE build I have to press Cmd+Shift+-,
> which doesn't seem to be right...

What?? Cmd+Shift++ doesn't open the help?? Cmd+Shift+- should not open help on Swedish layout.
Pressing Cmd+Shift++ makes the Help menu flash, but nothing happens. Pressing Cmd+Shift+- opens the help placeholder page in a new tab
(In reply to comment #17)
> Pressing Cmd+Shift++ makes the Help menu flash, but nothing happens. Pressing
> Cmd+Shift+- opens the help placeholder page in a new tab

mmmm. It seems that it's same bug as bug 306585 comment 15 and bug 306585 comment 36.

Please file a new bug, it may be only 10.5 issue.
(In reply to comment #18)
> mmmm. It seems that it's same bug as bug 306585 comment 15 and bug 306585
> comment 36.

Yes, I can reproduce on 10.5.
When pressing Cmd+Shift+- on Swedish layout, unshiftedChar is '/' and
shiftedChar is '?'.
Sakai-san, thank you.

Can the bug be fixed by the patch of bug 432388? That tries to get KCHR resouce with GetResource first.
> Please file a new bug, it may be only 10.5 issue.

Filed bug 432632.
(In reply to comment #21)
> > Please file a new bug, it may be only 10.5 issue.
> 
> Filed bug 432632.

thanks!
(In reply to comment #20)
> Can the bug be fixed by the patch of bug 432388? That tries to get KCHR resouce
> with GetResource first.

Not fixed.

::GetResource('kchr', kt.mLayoutID) returns 0.
(In reply to comment #23)
> (In reply to comment #20)
> > Can the bug be fixed by the patch of bug 432388? That tries to get KCHR resouce
> > with GetResource first.
> 
> Not fixed.
> 
> ::GetResource('kchr', kt.mLayoutID) returns 0.

Thank you...
You need to log in before you can comment on or make changes to this bug.