432163 - if start page is a file:// url, firefox shows go button instead of star

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Bill Gianopoulos [:WG9s]]

IF your startpage is a file:// type url, Firefox shows the go button instead of the star in the addressbar.  This is a regression which did NOT occur in beta5.

Comment 1

[Bill Gianopoulos [:WG9s]]

This happens on Windows as well.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008050406 Minefield/3.0pre ID:2008050406

OS -> All

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

This will not block the final release of Firefox 3. Any patch will need unit tests in order to be approved.

Comment 3

[Dão Gottwald [:dao]]

Attachment: don't set pageproxystate="invalid" in delayedStartup()

Not sure why this regressed now, a range would be helpful.

Comment 4

[Dão Gottwald [:dao]]

Just tested the 2008-04-05-04 nightly, and this bug occurred only occasionally. Seems like delayedStartup and pageload are really racing. Maybe pageload got a little bit faster recently.

Comment 5

[Bill Gianopoulos [:WG9s]]

(In reply to comment #3)
> Created an attachment (id=319439) [details]
> don't set pageproxystate="invalid" in delayedStart
> 
> Not sure why this regressed now, a range would be helpful.
> 
Checkins during regression window:

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2008-04-17+04%3A13&maxdate=2008-04-18+04%3A02&cvsroot=%2Fcvsroot

Comment 6

[Bill Gianopoulos [:WG9s]]

(In reply to comment #3)
> Created an attachment (id=319439) [details]
> don't set pageproxystate="invalid" in delayedStart

This fixes the issue for me.

Comment 7

[Bill Gianopoulos [:WG9s]]

(In reply to comment #2)
> This will not block the final release of Firefox 3. Any patch will need unit
> tests in order to be approved.
> 

This will be a more visible issue for builds included with linux distributions, which tend to come with start pages set to things like "file:///usr/share/doc/HTML/index.html"

Comment 8

[Bill Gianopoulos [:WG9s]]

This was regressed by the check-in for bug 425814.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 319439 [details] [diff] [review]
don't set pageproxystate="invalid" in delayedStartup()

Blake moved this from browserStartup() to delayed startup in revision 1.107 of browser.js, with no indication of why :(

I don't think we need to take this for Firefox 3.

Comment 10

[Bill Gianopoulos [:WG9s]]

(In reply to comment #9)
> (From update of attachment 319439 [details] [diff] [review])
> Blake moved this from browserStartup() to delayed startup in revision 1.107 of
> browser.js, with no indication of why :(

It still seems to be done in Startup in navigator.js.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/mozilla-central/index.cgi/rev/5034371d2778

Comment 13

[Samuel Sidler (old account; do not CC)]

Comment on attachment 319439 [details] [diff] [review]
don't set pageproxystate="invalid" in delayedStartup()

Approved for 1.9.0.2. Please land in CVS. a=ss

Comment 14

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/base/content/browser.js 	1.1037
mozilla/browser/base/content/browser.xul 	1.467 

Comment 15

[Al Billings [:abillings - ex-MoCo]]

Verified for 1.9.0.2 with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.2) Gecko/2008090212 Firefox/3.0.2.