432200 - Loose ampersand in 'unresponsive script' dialogue box

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[philippe (part-time)]

Attachment: the offender

Next to the 'don't ask me again' checkbox there is an ampersand that doesn't seem to make too much sense.

Seen with the 20080501 trunk build.

Comment 1

[Stuart Morgan]

This must be another shortcut marker sneaking through (bug 244670)

Comment 2

[Chris Lawson (gone)]

D'oh. CVS blame says bug 413884 broke this.

http://mxr.mozilla.org/mozilla/source/dom/locales/en-US/chrome/dom/dom.properties#46

Apparently that & gets hidden somehow by non-embedding apps or something...

This should probably be kicked to Core:DOM, but leaving in Camino for now until someone figures out whether this is purely a Camino bug, an embedding bug, or something that Core should figure out another means to solve.

For the record, the above looks like a file that would ordinarily have l10n implications as well. Smokey, how do we currently handle this? I suppose we could just strip out the & (since the bug it's intended to fix, accesskeys, doesn't apply to native Cocoa sheets) during the build process if we had to...

Comment 3

[Chris Lawson (gone)]

Ah, presumably we could use the strategy from bug 244670 again, then.

We should probably audit our sheets to ensure this doesn't happen again. I suspect it could be important again when the security certificate UI stuff gets done for 2.0.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #3)
> Ah, presumably we could use the strategy from bug 244670 again, then.

We should figure out why the code from bug 244670 is not working here.

Comment 5

[Stuart Morgan]

We only route button names through that function; we need to run checkbox strings through it as well.

(In reply to comment #3)
> I suspect it could be important again when the security certificate UI stuff
> gets done for 2.0.

Since that UI will be custom, that's highly unlikely.

Comment 6

[Chris Lawson (gone)]

Attachment: fix v1

This ought to do it.

Comment 7

[Chris Lawson (gone)]

Attachment: fix v2

Bulletproofs all instances of checkbox titles in CocoaPromptService so this can't happen again.

I guess in theory we could do it in nsAlertController too, but as far as I know CPS is the only place these Gecko-caused shortcuts can come through.

Comment 8

[Stuart Morgan]

Comment on attachment 324538 [details] [diff] [review]
fix v2

r=me

Comment 9

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 324538 [details] [diff] [review]
fix v2

sr=pink

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on trunk.