432216 - Changing options from the add-ons dialog doesn't work

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Hagen Halbach [:Fux]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.14) Gecko/20080404 Firefox/2.0.0.14
Build Identifier: ChatZilla 0.9.82 [Firefox 2.0.0.14/2008040413]

If I want to change the options from the add-ons dialog, nothing will be saved and I get this error: http://img244.imageshack.us/img244/8946/chatzillaerrorsi9.png

Reproducible: Always

Steps to Reproduce:
1. open Tools>Add-ons>Extensions>ChatZilla>Options in Firefox
2. use apply or ok

Actual Results:  
Alert http://img244.imageshack.us/img244/8946/chatzillaerrorsi9.png is comming, nothing will be saved

Expected Results:  
Options will be saved, dialog closes

Comment 1

[James Ross]

Attachment: Only call CEIP functions if we have client.ceip

Comment 2

[James Ross]

As a workaround, you can still use the preferences window from ChatZilla itself.

Comment 3

[:Gijs (he/him)]

Comment on attachment 319380 [details] [diff] [review]
Only call CEIP functions if we have client.ceip

>Index: xul/content/config.js

>@@ -1609,16 +1611,17 @@ function pwin_onAddObject()
>     
>     // Show add dialog, passing the data object along.
>     window.openDialog("config-add.xul", "cz-config-add", "chrome,dialog,modal", rv);
>     
>     if (!rv.ok)
>         return;
>-    
>-    client.ceip.logEvent({type: "dialog", dialog: "config", event: "add",
>-                          prefType: rv.type});
>-    
>+
>+    if (client.ceip)
>+        client.ceip.logEvent({type: "dialog", dialog: "config", event: "add",
>+                              prefType: rv.type});
>+

This one needs braces. :-)

>@@ -1650,16 +1653,17 @@ function pwin_onDeleteObject()
>     // Save current node before we re-select.
>     var sel = this.currentObject;
>     
>     // Check they want to go ahead.
>     if (!confirm(getMsg(MSG_PREFS_OBJECT_DELETE, sel.parent.unicodeName)))
>         return;
>-    
>-    client.ceip.logEvent({type: "dialog", dialog: "config", event: "delete",
>-                          prefType: sel.parent.TYPE});
>-    
>+
>+    if (client.ceip)
>+        client.ceip.logEvent({type: "dialog", dialog: "config", event: "delete",
>+                              prefType: sel.parent.TYPE});
>+

Ditto.

>@@ -1688,16 +1692,17 @@ function pwin_onResetObject()
>     // Save current node before we re-select.
>     var sel = this.currentObject;
>     
>     // Check they want to go ahead.
>     if (!confirm(getMsg(MSG_PREFS_OBJECT_RESET, sel.parent.unicodeName)))
>         return;
>-    
>-    client.ceip.logEvent({type: "dialog", dialog: "config", event: "reset",
>-                          prefType: sel.parent.TYPE});
>-    
>+
>+    if (client.ceip)
>+        client.ceip.logEvent({type: "dialog", dialog: "config", event: "reset",
>+                              prefType: sel.parent.TYPE});
>+

Ditto.

With that, r=me.

Comment 4

[James Ross]

Checked in --> FIXED.