432272 - Use -moz-padding-end and -moz-padding-start instead of padding-right and padding-left in tree(-aero).css

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[(no longer active)]

Follow-up from bug 431195 comment 13.  I'll post a patch as soon as bug 431195 lands, to make the padding rules RTL-agnostic.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Simple patch to use -moz-padding-{start,end} instead of padding-{left,right} (or combined padding CSS rules).

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 319744 [details] [diff] [review]
Patch (v1)

Can you do the same for gnomestripe?

>@@ -260,21 +260,27 @@ treecolpicker:hover:active {
>   border-top: 2px solid;
>   border-right: 1px solid;
>   border-bottom: 1px solid;
>   border-left: 2px solid;
>   -moz-border-top-colors: ThreeDShadow -moz-Dialog;
>   -moz-border-right-colors: ThreeDShadow;
>   -moz-border-bottom-colors: ThreeDShadow;
>   -moz-border-left-colors: ThreeDShadow -moz-Dialog;
>-  padding: 1px 4px 0px 5px;
>+  padding-top: 1px;
>+  padding-bottom: 0px;
>+  -moz-padding-start: 4px;
>+  -moz-padding-end: 5px;

You mixed up start/end.

> .treecol-image:hover:active {
>-  padding: 1px 1px 0px 2px;
>+  padding-top: 1px;
>+  padding-bottom: 0px;
>+  -moz-padding-start: 1px;
>+  -moz-padding-end: 2px;

same here

Comment 3

[(no longer active)]

Attachment: Patch (v1.1)

(In reply to comment #2)
> (From update of attachment 319744 [details] [diff] [review])
> Can you do the same for gnomestripe?

Sure, done.  I looked at pinstripe's tree.css as well, but it was all handled already.

I also went ahead and corrected a few margin rules as well.

> You mixed up start/end.

Oops!  Fixed.

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 320042 [details] [diff] [review]
Patch (v1.1)

>Index: toolkit/themes/gnomestripe/global/tree.css

> .treecol-image:hover:active {
>-  padding: 0px 0px 0px 2px;
>+  padding-top: 0px;
>+  padding-bottom: 0px;
>+  -moz-padding-start: 2px;
>+  -moz-padding-end: 0px;

As done elsewhere, I'd write this as:

  padding: 0;
  -moz-padding-start: 2px;

Comment 5

[(no longer active)]

Attachment: Patch (v1.2)

Fixed Dao's comment 4.  Requesting approval.  This is a CSS-only change with no impact on LTR locales, while improving things a bit for RTL locales.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

mozilla/toolkit/themes/gnomestripe/global/tree.css 	1.12
mozilla/toolkit/themes/winstripe/global/tree-aero.css 	1.3
mozilla/toolkit/themes/winstripe/global/tree.css 	1.15